Summary:ASTERISK-10671: [patch] Improved support of QoS in channels using RTP
Reporter:Igor Goncharovsky (igorg)Labels:
Date Opened:2007-11-02 04:04:19Date Closed:2007-12-16 04:48:49.000-0600
Versions:Frequency of
Environment:Attachments:( 0) qoscleanup-88197-1.patch
( 1) qoscleanup-88863-2.patch
( 2) qoscleanup-89312-3-svn.patch
( 3) qoscleanup-89394-4-trunk.patch
Description:What have done with this patch

- Improved logging: log also channel name
- Do not log QoS values when it have zero value
- Add support for QoS in chan_skinny
- Add support of QoS for RTP in chan_mgcp
- Rename config parameter in h323.conf from tos to tos_audio, because it set tos only for RTP
- Improved documentation


Documentation in qos.tex is not well yet, but I'll work on it. I think next patch will be ready to commit, this is for review only.
Comments:By: Igor Goncharovsky (igorg) 2007-11-06 01:00:24.000-0600

Updated to add QoS to chan_unistim. Some documentation improvement still needed.

By: Igor Goncharovsky (igorg) 2007-11-16 00:15:59.000-0600

Ok, now it seems to be ready.

I have also added some verbose message for OS other then Linux: now setting cos in any config file will cause verbose message. Or warning better in this case?

By: Eliel Sardanons (eliel) 2007-11-17 19:10:32.000-0600

I suggest not to put a documentation file reference in your logs like 'doc/qos.tex', because some day it could be changed to QOS.tex or qos.txt or something and no one will notice that to replace the ast_log.

By: Igor Goncharovsky (igorg) 2007-11-17 22:36:19.000-0600

Ok, eliel, any suggestions about how to reference to documentation?

Some time ago I have already change this from tos.txt to qos.tex. I agree with you that it is not best way to reference on documentation. My proposal is:
1) Delete all records of qos.tex in source
2) Extend records in config files to "qos.tex document file of Quality of Service section of asterisk.pdf"

By: Eliel Sardanons (eliel) 2007-11-18 09:16:19.000-0600

I don't have a suggestion to resolve this problem... hmmm, maybe just 'refer to Quality of service documentation' without telling the end user where it is, it will be not hard to find it I think..

By: Igor Goncharovsky (igorg) 2007-11-18 22:03:13.000-0600

- Added warning for systems where we can't set 802.1p
- No reference to qos.tex in source code
- Some mistakes

By: Olle Johansson (oej) 2007-12-16 03:57:13.000-0600

This seems fine to me, but why do you change the default values in chan_sip?

Otherwise, do you think this patch is ready for commit?

By: Igor Goncharovsky (igorg) 2007-12-16 04:22:07.000-0600

I add this variables in previous patch. This values really must be zero to do nothing on system where this options unused.

If there is no spelling issues in qos.tex and this have enough information, this really ready to commit.

By: Olle Johansson (oej) 2007-12-16 04:24:32.000-0600

That's a change from previous versions that needs to be discussed, but the rest is ok.

By: Olle Johansson (oej) 2007-12-16 04:28:05.000-0600

We need to be backwards compatible too, so we can't change config options that dramatically. I'll see what I can do.

By: Igor Goncharovsky (igorg) 2007-12-16 04:37:38.000-0600

I change only options for 802.1p priority, this introduced only few moth ago by me in trunk. I think all is OK in changing this values.

By: Digium Subversion (svnbot) 2007-12-16 04:48:48.000-0600

Repository: asterisk
Revision: 93163

U   trunk/CHANGES
U   trunk/UPGRADE.txt
U   trunk/channels/chan_h323.c
U   trunk/channels/chan_iax2.c
U   trunk/channels/chan_mgcp.c
U   trunk/channels/chan_sip.c
U   trunk/channels/chan_skinny.c
U   trunk/channels/chan_unistim.c
U   trunk/channels/iax2-provision.c
U   trunk/configs/dundi.conf.sample
U   trunk/configs/h323.conf.sample
U   trunk/configs/iax.conf.sample
U   trunk/configs/iaxprov.conf.sample
U   trunk/configs/mgcp.conf.sample
U   trunk/configs/sip.conf.sample
U   trunk/configs/skinny.conf.sample
U   trunk/configs/unistim.conf.sample
U   trunk/doc/tex/qos.tex
U   trunk/include/asterisk/netsock.h
U   trunk/include/asterisk/rtp.h
U   trunk/main/netsock.c
U   trunk/main/rtp.c
U   trunk/main/udptl.c
U   trunk/pbx/pbx_dundi.c

r93163 | oej | 2007-12-16 04:48:47 -0600 (Sun, 16 Dec 2007) | 17 lines

HUGE improvements to QoS/CoS handling by IgorG

- Refer to the proper documentation
- Implement separate signalling/media QoS/CoS in many channels using RTP
- Improve warnings and verbose messages
- Deprecate some old settings

Minor modifications by me, a big effort from IgorG.

Reported by: IgorG
     qoscleanup-89394-4-trunk.patch uploaded by IgorG (license 20)
Tested by: IgorG
(closes issue ASTERISK-10671)