Summary:	ASTERISK-10670: [patch] Fix small memory leak in config file proccessing when there are included files
Reporter:	James Golovich (jamesgolovich)	Labels:
Date Opened:	2007-11-02 02:45:09	Date Closed:	2007-11-02 10:22:35
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-configincludeleak.diff.txt
Description:	Noticed a memory leak when I would reload a specific module that I had setup to include a few files.  Turns out the code was caching the name of the files every time instead of only doing it once per file.
Comments:	By: Digium Subversion (svnbot) 2007-11-02 08:16:01 Repository: asterisk Revision: 88212 U   trunk/main/config.c ------------------------------------------------------------------------ r88212 | tilghman | 2007-11-02 08:16:01 -0500 (Fri, 02 Nov 2007) | 5 lines Don't re-cache the filename, but check to see if it already exists Reported by: jamesgolovich Patch by: jamesgolovich Closes issue ASTERISK-10670 ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-11-02 10:22:35 Repository: asterisk Revision: 88246 _U  team/group/CDRfix5/ U   team/group/CDRfix5/UPGRADE.txt U   team/group/CDRfix5/apps/app_dial.c U   team/group/CDRfix5/apps/app_exec.c U   team/group/CDRfix5/apps/app_macro.c U   team/group/CDRfix5/apps/app_minivm.c U   team/group/CDRfix5/apps/app_mixmonitor.c U   team/group/CDRfix5/apps/app_playback.c U   team/group/CDRfix5/apps/app_queue.c U   team/group/CDRfix5/apps/app_rpt.c U   team/group/CDRfix5/cdr/cdr_custom.c U   team/group/CDRfix5/cdr/cdr_manager.c U   team/group/CDRfix5/cdr/cdr_odbc.c U   team/group/CDRfix5/cdr/cdr_sqlite3_custom.c U   team/group/CDRfix5/channels/chan_gtalk.c U   team/group/CDRfix5/channels/chan_jingle.c U   team/group/CDRfix5/configure U   team/group/CDRfix5/configure.ac U   team/group/CDRfix5/funcs/func_cut.c U   team/group/CDRfix5/funcs/func_logic.c U   team/group/CDRfix5/funcs/func_odbc.c U   team/group/CDRfix5/funcs/func_strings.c U   team/group/CDRfix5/include/asterisk/autoconfig.h.in U   team/group/CDRfix5/include/asterisk/jabber.h U   team/group/CDRfix5/include/asterisk/lock.h U   team/group/CDRfix5/include/asterisk/pbx.h U   team/group/CDRfix5/main/config.c U   team/group/CDRfix5/main/logger.c U   team/group/CDRfix5/main/pbx.c U   team/group/CDRfix5/makeopts.in U   team/group/CDRfix5/pbx/pbx_config.c U   team/group/CDRfix5/pbx/pbx_dundi.c U   team/group/CDRfix5/pbx/pbx_loopback.c U   team/group/CDRfix5/pbx/pbx_realtime.c U   team/group/CDRfix5/res/ael/pval.c U   team/group/CDRfix5/res/res_agi.c U   team/group/CDRfix5/res/res_jabber.c U   team/group/CDRfix5/utils/extconf.c ------------------------------------------------------------------------ r88246 | murf | 2007-11-02 10:22:34 -0500 (Fri, 02 Nov 2007) | 73 lines Merged revisions 88164-88166,88182-88184,88197,88209,88211-88212 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r88164 | qwell | 2007-11-01 16:10:33 -0600 (Thu, 01 Nov 2007) | 4 lines Switch res_jabber to use openssl rather than gnutls. Closes issue ASTERISK-9675, patch by phsultan.  Copied from branch at http://svn.digium.com/svn/asterisk/team/phsultan/res_jabber-openssl/ ................ r88165 | qwell | 2007-11-01 16:19:56 -0600 (Thu, 01 Nov 2007) | 1 line Crap, accidentally copied the props.  Thanks for pointing this out mvanbaak.  The odds are quite high that this will break automerge on every team branch. ................ r88166 | murf | 2007-11-01 16:26:51 -0600 (Thu, 01 Nov 2007) | 1 line This commits the performance mods that give the priority processing engine in the pbx, a 25-30peed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9peedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc. ................ r88182 | tilghman | 2007-11-01 16:43:46 -0600 (Thu, 01 Nov 2007) | 3 lines Convert cdr_odbc to use res_odbc managed connections Closes issue ASTERISK-10209 ................ r88183 | tilghman | 2007-11-01 17:26:35 -0600 (Thu, 01 Nov 2007) | 3 lines Modify WaitExten to include an optional dialtone Closes issue ASTERISK-10356 ................ r88184 | qwell | 2007-11-01 17:26:51 -0600 (Thu, 01 Nov 2007) | 1 line Remove traces of gnutls, since we no longer use/need it. ................ r88197 | file | 2007-11-01 21:09:02 -0600 (Thu, 01 Nov 2007) | 2 lines Restore building under 64-bit platforms. ................ r88209 | tilghman | 2007-11-02 06:54:31 -0600 (Fri, 02 Nov 2007) | 5 lines 'h' extension doesn't execute past first priority Reported by: dimas Patch by: dimas Closes bug ASTERISK-10672 ................ r88211 | tilghman | 2007-11-02 07:10:29 -0600 (Fri, 02 Nov 2007) | 13 lines Merged revisions 88210 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r88210 | tilghman | 2007-11-02 08:03:03 -0500 (Fri, 02 Nov 2007) | 5 lines Fix build on Solaris Reported by: snuffy Patch by: ys Closes issue ASTERISK-10669 ........ ................ r88212 | tilghman | 2007-11-02 07:17:48 -0600 (Fri, 02 Nov 2007) | 5 lines Don't re-cache the filename, but check to see if it already exists Reported by: jamesgolovich Patch by: jamesgolovich Closes issue ASTERISK-10670 ................ ------------------------------------------------------------------------