[Home]

Summary:ASTERISK-10668: [PATCH] Better handling of temporary channel name. Fixes FOP.
Reporter:Julian J. M. (julianjm)Labels:
Date Opened:2007-11-01 19:16:27Date Closed:2008-04-02 14:31:22
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_misdn
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_misdn_tmpchan_trunk_v1.diff
( 1) chan_misdn_tmpchan_v2.diff
Description:When dialing out a misdn channel, either by using a group (g:group), or a port, asterisk creates the channel with a tmp channel number: mISDN/X-uY, with X being (port-1)*2. Y not important.

Port 0: temporal channel name 0. BChannels 1 and 2
Port 1: temporal channel name 2. BChannels 3 and 4
Port 2: temporal channel name 4. BChannels 5 and 6

As you can see, temporal channel for port 1 conflicts with real channel 2 for port 0. This is not consistent.

This patch forces temporal channels (those for which we have not a B channel yet), to be named mISDN/tmpX-uY.

Also, it will rename the channel using the ast_change_name() function, which generates "rename" events, and can be followed by manager events.

As a plus, it will make FOP work correctly with misdn channels.
Comments:By: crich (crich) 2007-11-16 03:44:49.000-0600

the patch doesn't apply to trunk anymore, do you mind to update it ? then i'll test and check it in.

By: Julian J. M. (julianjm) 2007-11-16 04:23:36.000-0600

Yeah, the first patch was for the 1.4 branch. Just uploaded one for trunk (rev 89320).

Julian J. M.

By: Digium Subversion (svnbot) 2008-04-02 14:30:09

Repository: asterisk
Revision: 112520

U   trunk/channels/chan_misdn.c

------------------------------------------------------------------------
r112520 | tilghman | 2008-04-02 14:30:06 -0500 (Wed, 02 Apr 2008) | 6 lines

Make MISDN generate channel rename events when the name changes.
(closes issue ASTERISK-10668)
Reported by: julianjm
Patches:
      chan_misdn_tmpchan_trunk_v1.diff uploaded by julianjm (license 99)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112520

By: Digium Subversion (svnbot) 2008-04-02 14:31:21

Repository: asterisk
Revision: 112521

_U  branches/1.6.0/

------------------------------------------------------------------------
r112521 | tilghman | 2008-04-02 14:31:21 -0500 (Wed, 02 Apr 2008) | 13 lines

Blocked revisions 112520 via svnmerge

........
r112520 | tilghman | 2008-04-02 14:34:52 -0500 (Wed, 02 Apr 2008) | 6 lines

Make MISDN generate channel rename events when the name changes.
(closes issue ASTERISK-10668)
Reported by: julianjm
Patches:
      chan_misdn_tmpchan_trunk_v1.diff uploaded by julianjm (license 99)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112521