Summary: | ASTERISK-10654: [patch] Check before trying to free in utils.c | ||
Reporter: | snuffy (snuffy) | Labels: | |
Date Opened: | 2007-10-30 17:38:26 | Date Closed: | 2007-11-01 01:10:23 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) patch-11125.diff | |
Description: | We should check before free'ing that its actually required. | ||
Comments: | By: Tilghman Lesher (tilghman) 2007-10-30 18:13:45 Did this actually create a crash/core dump? By: snuffy (snuffy) 2007-10-30 19:31:20 It does not cause a crash. This just creates a warning, which you can see when you have memory profiling turned on. Here's mmlog msg.. this happens when I shutdown asterisk by 'stop gracefully' or 'stop now' WARNING: Freeing unused memory at (nil), in lock_info_destroy of utils.c, line 587 WARNING: Freeing unused memory at (nil), in lock_info_destroy of utils.c, line 587 WARNING: Freeing unused memory at (nil), in lock_info_destroy of utils.c, line 587 By: Digium Subversion (svnbot) 2007-11-01 01:10:23 Repository: asterisk Revision: 88010 U trunk/main/utils.c ------------------------------------------------------------------------ r88010 | tilghman | 2007-11-01 01:10:23 -0500 (Thu, 01 Nov 2007) | 5 lines Conditionally free lock_info->thread_name to avoid a useless warning Reported by: snuffy Patch by: snuffy Closes issue ASTERISK-10654 ------------------------------------------------------------------------ |