Summary:ASTERISK-10639: [patch] to better debug main DSP busydetect function
Reporter:Antonio Gallo (agx)Labels:
Date Opened:2007-10-29 12:20:20Date Closed:2008-01-17 14:49:00.000-0600
Versions:Frequency of
Environment:Attachments:( 0) busydetect_enhancement.patch
( 1) busydetect-r94827.diff
( 2) busydetect-r94975.diff
Description:In Italy there is no availability for polarityreversal switch so i've to do a little enhanchement to the code to capture dps.c handling the busy signal detection.

This patch adds:
- menuselect option to allow to choose the already in-place option about the different BUSYDETECT routines already implemented;
- main/dsp.c enhanched on-deman debugging using MENUSELECT_DEBUG flag and the common option_debug global variable;
- zap show channel ability to display wich busydetection parameters have been configured for the zap channel;
- documentation enhancement;

Platform: Linux Debian 4.0

The patch is again 1.4.13 svn: svn info
URL: http://svn.digium.com/svn/asterisk/tags/1.4.13
Repository Root: http://svn.digium.com/svn/asterisk
Revision: 87121
Last Changed Rev: 85320
Last Changed Date: 2007-10-10 18:06:23 +0200 (Wed, 10 Oct 2007)
Comments:By: Russell Bryant (russell) 2007-11-06 17:21:09.000-0600

I would consider this something that should only go in trunk.  Can you update the patch for trunk?

By: Antonio Gallo (agx) 2007-11-07 01:42:45.000-0600

At the moment i'm focused on having something stable and without bugs so honestly i've to say that i don't have time now to reserve time or other employers to setup another dev machine with svn trunk on it and doing testing with it.

By: Antonio Gallo (agx) 2007-11-20 06:33:36.000-0600

ok, plz give me a few days to prepare the patch against Trunk

By: Tilghman Lesher (tilghman) 2007-12-26 11:38:42.000-0600

It's been more than a few days.  Have you updated your patch against trunk yet?

By: Sergey Tamkovich (sergee) 2007-12-27 03:43:07.000-0600

This patch seems to be usefull for me, i'll port it to trunk today.

By: Sergey Tamkovich (sergee) 2007-12-27 05:57:21.000-0600

This version is adjusted against current trunk (rev 94827) with minor improvements.

By: Tilghman Lesher (tilghman) 2007-12-27 12:46:49.000-0600

1) Please don't use option_debug in combination with LOG_WARNING.  In fact, you should just be using the ast_debug() macro call.

2) Don't use multiple ast_cli calls to print out a single line.  Instead, separate out the format string on multiple lines and use the #ifd #elif #endif set of preprocessor commands to select which string to use.

By: Sergey Tamkovich (sergee) 2007-12-27 13:59:39.000-0600

Corydon76, thank you for guidance!

By: Digium Subversion (svnbot) 2008-01-17 14:48:59.000-0600

Repository: asterisk
Revision: 98998

U   trunk/Makefile
U   trunk/build_tools/cflags.xml
U   trunk/channels/chan_zap.c
U   trunk/configs/zapata.conf.sample
U   trunk/main/dsp.c

r98998 | qwell | 2008-01-17 14:48:58 -0600 (Thu, 17 Jan 2008) | 12 lines

Add several busy detection related defines to menuselect.
Allow better busy detect debugging (with BUSYDETECT_DEBUG).

Remove very old BUSYDETECT and BUSY_DETECT_MARTIN defines.

(closes issue ASTERISK-10639)
     busydetect_enhancement.patch uploaded by agx (license 298)
     busydetect-r94975.diff uploaded by sergee (license 138)

Additional changes/cleanup by me.