[Home]

Summary:ASTERISK-10628: [patch] Modify the return values on load_module().
Reporter:Eliel Sardanons (eliel)Labels:
Date Opened:2007-10-26 13:28:36Date Closed:2007-12-26 13:59:42.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_adsiprog.c.patch
( 1) app_alarmreceiver.c.patch
( 2) app_amd.c.patch
( 3) app_authenticate.c.patch
( 4) app_cdr.c.patch
( 5) app_zapateller.c.patch
( 6) app_zapbarge.c.patch
( 7) app_zapras.c.patch
( 8) app_zapscan.c.patch
( 9) chan_agent.c.patch
(10) chan_features.c.patch
(11) chan_local.c.patch
(12) chan_zap.c.patch
(13) codec_a_mu.c.patch
(14) codec_adpcm.c.patch
(15) codec_alaw.c.patch
(16) codec_g722.c.patch
(17) codec_g726.c.diff
(18) codec_gsm.c.patch
(19) codec_ilbc.c.patch
(20) codec_lpc10.c.patch
(21) codec_speex.c.patch
(22) codec_ulaw.c.patch
(23) codec_zap.c.patch
(24) format_g723.c.patch
(25) format_g726.c.patch
(26) format_g729.c.patch
(27) format_gsm.c.patch
(28) format_h263.c.patch
(29) format_h264.c.patch
(30) format_ilbc.c.patch
(31) format_jpeg.c.patch
(32) format_ogg_vorbis.c.patch
(33) format_pcm.c.patch
(34) format_sln.c.patch
(35) format_vox.c.patch
(36) format_wav_gsm.c.patch
(37) format_wav.c.patch
(38) pbx_config.c.patch
(39) pbx_dundi.c.patch
(40) pbx_gtkconsole.c.patch
(41) pbx_loopback.c.patch
(42) pbx_realtime.c.patch
(43) pbx_spool.c.patch
(44) res_adsi.c.patch
(45) res_ael_share.c.patch
(46) res_clioriginate.c.patch
(47) res_convert.c.patch
(48) res_crypto.c.patch
(49) res_indications.c.patch
(50) res_monitor.c.patch
(51) res_musiconhold.c.patch
(52) res_realtime.c.patch
(53) res_smdi.c.patch
(54) res_speech.c.patch
Description:Start using AST_MODULE_LOAD_SUCCESS, AST_MODULE_LOAD_DECLINE, AST_MODULE_LOAD_FAILURE and AST_MODULE_LOAD_SKIP instead of their values.
This is usefull for future changes on the return values of this functions and also to notice that some modules on failure are returning 0 (AST_MODULE_LOAD_SUCCESS) instead of the corresponding return value.

****** ADDITIONAL INFORMATION ******

enum ast_module_load_result {
       AST_MODULE_LOAD_SUCCESS = 0,    /*!< Module loaded and configured */
       AST_MODULE_LOAD_DECLINE = 1,    /*!< Module is not configured */
       AST_MODULE_LOAD_SKIP = 2,       /*!< Module was skipped for some reason */
       AST_MODULE_LOAD_FAILURE = -1,   /*!< Module could not be loaded properly */
};
Comments:By: Eliel Sardanons (eliel) 2007-10-26 13:47:15

Sorry, I forgot the '[patch]' on the summary.
By: Jason Parker (jparker) 2007-10-26 14:26:50

Are there more still outstanding?  If so, I'll wait to commit.
By: Eliel Sardanons (eliel) 2007-10-26 14:32:15

qwell, yes, there are more, you can start commiting this patches, but don't close this issue, so I can continue uploading more.
By: Digium Subversion (svnbot) 2007-10-26 16:35:28

Repository: asterisk
Revision: 87202

U   trunk/channels/chan_agent.c
U   trunk/channels/chan_features.c
U   trunk/channels/chan_local.c
U   trunk/channels/chan_zap.c
U   trunk/res/res_crypto.c
U   trunk/res/res_monitor.c
U   trunk/res/res_realtime.c

------------------------------------------------------------------------
r87202 | qwell | 2007-10-26 16:35:27 -0500 (Fri, 26 Oct 2007) | 12 lines

Correctly use defined return values in (some) load_module functions.

(issue ASTERISK-10628)
Patches:
     chan_agent.c.patch uploaded by eliel (license 64)
     chan_local.c.patch uploaded by eliel (license 64)
     chan_features.c.patch uploaded by eliel (license 64)
     chan_zap.c.patch uploaded by eliel (license 64)
     res_monitor.c.patch uploaded by eliel (license 64)
     res_realtime.c.patch uploaded by eliel (license 64)
     res_crypto.c.patch uploaded by eliel (license 64)

------------------------------------------------------------------------
By: Moises Silva (moy) 2007-10-26 22:59:48

codecs done
By: Moises Silva (moy) 2007-10-28 11:17:18

formats done
By: Digium Subversion (svnbot) 2007-10-31 14:22:46

Repository: asterisk
Revision: 87889

U   trunk/codecs/codec_a_mu.c
U   trunk/codecs/codec_adpcm.c
U   trunk/codecs/codec_alaw.c
U   trunk/codecs/codec_g722.c
U   trunk/codecs/codec_g726.c
U   trunk/codecs/codec_gsm.c
U   trunk/codecs/codec_ilbc.c
U   trunk/codecs/codec_lpc10.c
U   trunk/codecs/codec_speex.c
U   trunk/codecs/codec_ulaw.c
U   trunk/codecs/codec_zap.c
U   trunk/formats/format_g723.c
U   trunk/formats/format_g726.c
U   trunk/formats/format_g729.c
U   trunk/formats/format_gsm.c
U   trunk/formats/format_h263.c
U   trunk/formats/format_h264.c
U   trunk/formats/format_ilbc.c
U   trunk/formats/format_jpeg.c
U   trunk/formats/format_ogg_vorbis.c
U   trunk/formats/format_pcm.c
U   trunk/formats/format_sln.c
U   trunk/formats/format_vox.c
U   trunk/formats/format_wav.c
U   trunk/formats/format_wav_gsm.c
U   trunk/res/res_adsi.c
U   trunk/res/res_ael_share.c
U   trunk/res/res_clioriginate.c
U   trunk/res/res_convert.c
U   trunk/res/res_indications.c
U   trunk/res/res_musiconhold.c
U   trunk/res/res_smdi.c
U   trunk/res/res_speech.c

------------------------------------------------------------------------
r87889 | qwell | 2007-10-31 14:22:45 -0500 (Wed, 31 Oct 2007) | 38 lines

More changes to change return values from load_module functions.

(issue ASTERISK-10628)
Patches:
     codec_adpcm.c.patch uploaded by moy (license 222)
     codec_alaw.c.patch uploaded by moy (license 222)
     codec_a_mu.c.patch uploaded by moy (license 222)
     codec_g722.c.patch uploaded by moy (license 222)
     codec_g726.c.diff uploaded by moy (license 222)
     codec_gsm.c.patch uploaded by moy (license 222)
     codec_ilbc.c.patch uploaded by moy (license 222)
     codec_lpc10.c.patch uploaded by moy (license 222)
     codec_speex.c.patch uploaded by moy (license 222)
     codec_ulaw.c.patch uploaded by moy (license 222)
     codec_zap.c.patch uploaded by moy (license 222)
     format_g723.c.patch uploaded by moy (license 222)
     format_g726.c.patch uploaded by moy (license 222)
     format_g729.c.patch uploaded by moy (license 222)
     format_gsm.c.patch uploaded by moy (license 222)
     format_h263.c.patch uploaded by moy (license 222)
     format_h264.c.patch uploaded by moy (license 222)
     format_ilbc.c.patch uploaded by moy (license 222)
     format_jpeg.c.patch uploaded by moy (license 222)
     format_ogg_vorbis.c.patch uploaded by moy (license 222)
     format_pcm.c.patch uploaded by moy (license 222)
     format_sln.c.patch uploaded by moy (license 222)
     format_vox.c.patch uploaded by moy (license 222)
     format_wav.c.patch uploaded by moy (license 222)
     format_wav_gsm.c.patch uploaded by moy (license 222)
     res_adsi.c.patch uploaded by eliel (license 64)
     res_ael_share.c.patch uploaded by eliel (license 64)
     res_clioriginate.c.patch uploaded by eliel (license 64)
     res_convert.c.patch uploaded by eliel (license 64)
     res_indications.c.patch uploaded by eliel (license 64)
     res_musiconhold.c.patch uploaded by eliel (license 64)
     res_smdi.c.patch uploaded by eliel (license 64)
     res_speech.c.patch uploaded by eliel (license 64)

------------------------------------------------------------------------
By: Jason Parker (jparker) 2007-11-06 14:04:44.000-0600

Silly question - but were there more patches coming, or are we done here?
By: Eliel Sardanons (eliel) 2007-11-06 14:39:23.000-0600

There are more, I will continue uploading files, be patient... :-)
By: Jason Parker (jparker) 2007-11-15 14:52:36.000-0600

Suspend, per eliel, until he gets more time.
By: Jason Parker (jparker) 2007-11-15 15:03:17.000-0600

woops, didn't realize more patches were being uploaded.  Sorry moy. :)
By: Moises Silva (moy) 2007-11-15 23:24:31.000-0600

added several files for pbx and applications. pbx_* and app_*
By: Moises Silva (moy) 2007-12-08 15:03:50.000-0600

app_zap* files added for revision 91983
By: Digium Subversion (svnbot) 2007-12-26 13:59:02.000-0600

Repository: asterisk
Revision: 94806

U   trunk/apps/app_adsiprog.c
U   trunk/apps/app_alarmreceiver.c
U   trunk/apps/app_amd.c
U   trunk/apps/app_authenticate.c
U   trunk/apps/app_cdr.c
U   trunk/apps/app_zapateller.c
U   trunk/apps/app_zapbarge.c
U   trunk/apps/app_zapras.c
U   trunk/apps/app_zapscan.c
U   trunk/pbx/pbx_config.c
U   trunk/pbx/pbx_dundi.c
U   trunk/pbx/pbx_gtkconsole.c
U   trunk/pbx/pbx_loopback.c
U   trunk/pbx/pbx_realtime.c
U   trunk/pbx/pbx_spool.c

------------------------------------------------------------------------
r94806 | qwell | 2007-12-26 13:59:02 -0600 (Wed, 26 Dec 2007) | 20 lines

Use defined return values in load_module in more places.

(closes issue ASTERISK-10628)
Patches:
     pbx_config.c.patch uploaded by moy (license 222)
     pbx_dundi.c.patch uploaded by moy (license 222)
     pbx_gtkconsole.c.patch uploaded by moy (license 222)
     pbx_loopback.c.patch uploaded by moy (license 222)
     pbx_realtime.c.patch uploaded by moy (license 222)
     pbx_spool.c.patch uploaded by moy (license 222)
     app_adsiprog.c.patch uploaded by moy (license 222)
     app_alarmreceiver.c.patch uploaded by moy (license 222)
     app_amd.c.patch uploaded by moy (license 222)
     app_authenticate.c.patch uploaded by moy (license 222)
     app_cdr.c.patch uploaded by moy (license 222)
     app_zapateller.c.patch uploaded by moy (license 222)
     app_zapbarge.c.patch uploaded by moy (license 222)
     app_zapras.c.patch uploaded by moy (license 222)
     app_zapscan.c.patch uploaded by moy (license 222)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=94806
By: Jason Parker (jparker) 2007-12-26 13:59:42.000-0600

Please request reopen if there are more patches needed here.