Summary: | ASTERISK-10612: hidecalleridname parameter don't work | ||
Reporter: | Dmitry Dudkin (ddv2005) | Labels: | |
Date Opened: | 2007-10-24 15:38:08 | Date Closed: | 2007-10-24 15:57:31 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_zap |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) chan_zap_patch.txt | |
Description: | hidecalleridname parameter can't work because variable 'n' overrided at bellow code in anyway. if (!p->hidecalleridname) n = ast->cid.cid_name; else n = NULL; if (!p->hidecallerid) { l = ast->cid.cid_num; n = ast->cid.cid_name; } else { l = NULL; n = NULL; } ****** ADDITIONAL INFORMATION ****** --- old/chan_zap.c 2007-10-05 12:44:21.000000000 -0400 +++ chan_zap.c 2007-10-24 10:13:03.000000000 -0400 @@ -2064,7 +2064,6 @@ n = NULL; if (!p->hidecallerid) { l = ast->cid.cid_num; - n = ast->cid.cid_name; } else { l = NULL; n = NULL; | ||
Comments: | By: Digium Subversion (svnbot) 2007-10-24 15:57:31 Repository: asterisk Revision: 86983 _U trunk/ U trunk/channels/chan_zap.c ------------------------------------------------------------------------ r86983 | qwell | 2007-10-24 15:57:29 -0500 (Wed, 24 Oct 2007) | 14 lines Merged revisions 86982 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue ASTERISK-10612) ........ r86982 | qwell | 2007-10-24 15:56:47 -0500 (Wed, 24 Oct 2007) | 5 lines Correctly respect hidecalleridname configuration option. Simplify code slightly in the process. Issue 11079, reported by ddv2005 ........ ------------------------------------------------------------------------ |