[Home]

Summary:ASTERISK-10580: CLI tab completion broken on "dundi show peer"
Reporter:Jared Smith (jsmith)Labels:
Date Opened:2007-10-19 16:03:50Date Closed:2007-10-22 08:46:20
Priority:MinorRegression?No
Status:Closed/CompleteComponents:PBX/pbx_dundi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-dundicomplete.diff.txt
Description:CLI tab completion is broken on "dundi show peer".  It always selects one peer.

****** STEPS TO REPRODUCE ******

I do a "dundi show peers", and it shows that I have two peers:

hockey*CLI> dundi show peers
EID                  Host                Model      AvgTime  Status        
00:1a:92:44:f7:6c    XX.XX.36.140    (S) Symmetric  Unavail  OK (182 ms)    
00:17:31:01:cd:bb    192.168.0.100   (S) Symmetric  Unavail  OK (1 ms)      
2 dundi peers [2 online, 0 offline, 0 unmonitored]

Then, I type "dundi show peer " and hit the tab key, and it automatically fills in "00:17:31:01:cd:bb", even though there are two peers.

If I type "dundi show peer 00:1a" and press tab, it shows me the other peer.
Comments:By: James Golovich (jamesgolovich) 2007-10-20 01:13:37

This patch fixes the issue, which also was a memory leak.

Edit: This was against SVN trunk, but it should apply cleanly to 1.4


By: Digium Subversion (svnbot) 2007-10-22 08:45:04

Repository: asterisk
Revision: 86661

U   branches/1.4/pbx/pbx_dundi.c

------------------------------------------------------------------------
r86661 | file | 2007-10-22 08:45:03 -0500 (Mon, 22 Oct 2007) | 6 lines

Fix tab completion for dundi show peer.
(closes issue ASTERISK-10580)
Reported by: jsmith
Patches:
     asterisk-dundicomplete.diff.txt uploaded by jamesgolovich (license 176)

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-10-22 08:46:20

Repository: asterisk
Revision: 86662

_U  trunk/
U   trunk/pbx/pbx_dundi.c

------------------------------------------------------------------------
r86662 | file | 2007-10-22 08:46:19 -0500 (Mon, 22 Oct 2007) | 14 lines

Merged revisions 86661 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86661 | file | 2007-10-22 11:05:26 -0300 (Mon, 22 Oct 2007) | 6 lines

Fix tab completion for dundi show peer.
(closes issue ASTERISK-10580)
Reported by: jsmith
Patches:
     asterisk-dundicomplete.diff.txt uploaded by jamesgolovich (license 176)

........

------------------------------------------------------------------------