| Summary: | ASTERISK-10570: During transfers the local domain check fails if SIP phones provide a :portnr in their REFER message. | ||
| Reporter: | Ramon Peek-Fares (ramonpeek) | Labels: | |
| Date Opened: | 2007-10-18 12:14:28 | Date Closed: | 2007-10-19 10:15:42 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Transfers |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 11027.diff ( 1) 11027-1.diff | |
| Description: | During transfers the local domain check fails if SIP phones provide a :portnr in their REFER message. This causes the SIP Debug message: "This SIP transfer is to a remote SIP extension (remote domain pbx.example.net:5060)" And thus the localtransfer variable is not set and the call is handled as being a non-local transfer. Also no check is done to see whether the transfer is to a local domain or not, it only checks to see if allow external domains. But if we don't it does not check the local domains. | ||
| Comments: | By: Ramon Peek-Fares (ramonpeek) 2007-10-18 12:15:20 I've written a patch again 1.4.13 that solves issue, will upload. By: Ramon Peek-Fares (ramonpeek) 2007-10-18 12:51:58 I just read my own notes and though I needed to clarify a bit more. there are 2 issue's: Issue 1: The portnumber is not stripped of the domainname in case we have a phone that provides a portnumber in the REFER message. (Thomson phones do this!) Issue 2: During transfer asterisk checks that when external domains are allowed the domain is found in the domain list or if the domain list is empty. But when external domains are not allowed it does not check whether the referred domain is listed in the domainlist and therefor every domain is remote according to asterisk. And that is not true By: Ramon Peek-Fares (ramonpeek) 2007-10-18 13:05:06 Found a small cut & paste error in the patch, uploaded new patch: 11027-1.diff By: Digium Subversion (svnbot) 2007-10-19 10:13:01 Repository: asterisk Revision: 86471 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r86471 | file | 2007-10-19 10:13:00 -0500 (Fri, 19 Oct 2007) | 6 lines Fix two issues with domains and transfers. If a port was given in the hostname it was treated as part of the hostname. If domains were configured but external domains were not enabled all transfers would be considered remote. (closes issue ASTERISK-10570) Reported by: ramonpeek Patches: 11027-1.diff uploaded by ramonpeek (license 266) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-10-19 10:15:42 Repository: asterisk Revision: 86472 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r86472 | file | 2007-10-19 10:15:41 -0500 (Fri, 19 Oct 2007) | 14 lines Merged revisions 86471 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r86471 | file | 2007-10-19 12:33:49 -0300 (Fri, 19 Oct 2007) | 6 lines Fix two issues with domains and transfers. If a port was given in the hostname it was treated as part of the hostname. If domains were configured but external domains were not enabled all transfers would be considered remote. (closes issue ASTERISK-10570) Reported by: ramonpeek Patches: 11027-1.diff uploaded by ramonpeek (license 266) ........ ------------------------------------------------------------------------ | ||