Summary:ASTERISK-10568: Unavailable peer not show in BLF of Thomson and Grandstream phones
Reporter:Francesco Romano (francesco_r)Labels:
Date Opened:2007-10-18 09:35:44Date Closed:2008-03-28 17:32:02
Versions:Frequency of
Environment:Attachments:( 0) notify_thomson_xlite.txt
Description:I have upgraded some Asterisk 1.2.X machines to 1.4.13. Now when a peer is unavailable the BLF of Grandstream GXP2000 or Thomson ST2030 display the status of available (green led on GXP2000, led off on Thomson). With asterisk 1.2 the BLF status on unavailability was busy (led on). Only the Softphone X-Lite 3 display the correct status of a contact (Not online).
Comments:By: Francesco Romano (francesco_r) 2007-10-18 09:48:36

In the debug file i have attached 504 is Xlite, 503 is a Thomson phone.

By: Francesco Romano (francesco_r) 2007-10-18 09:56:21

This is the sip show subscriptions:      504         NzJiNjEyN2V  507@from-intern  Unavailable    pidf+xml        <none>     503         6b00-c0a801  507@from-intern  Unavailable    dialog-info+xml <none>

By: Olle Johansson (oej) 2007-11-15 06:44:16.000-0600

These lamps are interesting indeed. I will have to check the logs to see what we report. Stay tuned.

By: Alessandro Polverini (alessandro polverini) 2007-11-16 00:55:20.000-0600

I'm hit by the same bug.
Having the behavior restored to 1.2 would be very, very welcome.

By: Francesco Romano (francesco_r) 2008-01-05 02:50:40.000-0600

Any news on this bug?
Thank you

By: David Stirrup (dstirrup) 2008-02-19 23:37:38.000-0600

This sort of behaviour is old.

I think Thompson have identified the issue and created some cleanup code for chan_sip that should be merged into the main code as it is NOT a feature but CLEANING up the sip notify

Have a look at this URL


and go down to the patch links titled;
Asterisk 1.2 patch for Call Pickup (ZIP, 114.92K - 08/14/2007)  
Asterisk 1.4 patch for Call Pickup (ZIP, 367.88K - 10/18/2007)

By: Joshua C. Colp (jcolp) 2008-02-20 13:08:25.000-0600

If this is true we can't just put it into the tree, it has to be submitted on here by Thomson and properly licensed.

By: Francesco Romano (francesco_r) 2008-02-21 04:08:44.000-0600

I have applied the patch available in the Thomson site long time ago and works well for the pickup but the problem i have reported is still present. The lamps of the phone remains off when the peer is unavailable. So the problem i think it's in another place.

By: Francesco Romano (francesco_r) 2008-02-21 05:12:06.000-0600

I have resolved this.
I have compared the 1.4 code to the old 1.2 and in line 7157 of chan_sip.c (case AST_EXTENSION_UNAVAILABLE) i have changed from:
statestring = "terminated";
statestring = "confirmed";

And now is like the old behaviour.
Why this was changed?

By: Joshua C. Colp (jcolp) 2008-02-21 09:03:55.000-0600

This was changed a result of the commit from issue 8735.

By: Jason Parker (jparker) 2008-03-28 17:32:01

After discussing this, we agreed that the current behavior is what most people would expect.

As francesco_r pointed out, changing this is quite trivial.

If you disagree, what I would recommend is starting a discussion on the asterisk-dev mailing list, and seeing how many people think that it is incorrect.