[Home]

Summary:ASTERISK-10555: SIP MESSAGE request provokes disconnect after a dozen of seconds
Reporter:vadim (vadim)Labels:
Date Opened:2007-10-17 08:42:48Date Closed:2007-10-17 11:39:27
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The summary says it all

****** ADDITIONAL INFORMATION ******

Apparently the problem is provoked by the fact that function
receive_message in chan_sip.c  calls sip_scheddestroy on ALL execution pathes.
Avoiding this call in case of succesful relay fixes the problem
Comments:By: vadim (vadim) 2007-10-17 08:51:52

Looking int sources on the trunk and 1.2 the same bug seems to be present
everywhere
By: Digium Subversion (svnbot) 2007-10-17 09:46:30

Repository: asterisk
Revision: 86063

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r86063 | file | 2007-10-17 09:46:30 -0500 (Wed, 17 Oct 2007) | 4 lines

Don't schedule dialog destruction if a MESSAGE is received using an existing dialog.
(closes issue ASTERISK-10555)
Reported by: vadim

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-10-17 09:48:51

Repository: asterisk
Revision: 86064

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r86064 | file | 2007-10-17 09:48:51 -0500 (Wed, 17 Oct 2007) | 12 lines

Merged revisions 86063 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86063 | file | 2007-10-17 12:06:36 -0300 (Wed, 17 Oct 2007) | 4 lines

Don't schedule dialog destruction if a MESSAGE is received using an existing dialog.
(closes issue ASTERISK-10555)
Reported by: vadim

........

------------------------------------------------------------------------
By: vadim (vadim) 2007-10-17 11:32:25

The latest fixes are incomplete...
One should remove the call to 'sip_scheddestroy' at the end of receive_message function, otherwise it will be still called in case of sucessful relay...
By: Digium Subversion (svnbot) 2007-10-17 11:37:46

Repository: asterisk
Revision: 86117

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r86117 | file | 2007-10-17 11:37:45 -0500 (Wed, 17 Oct 2007) | 4 lines

Whoops, forgot to remove the original sip_scheddestroy.
(closes issue ASTERISK-10555)
Reported by: vadim

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-10-17 11:39:27

Repository: asterisk
Revision: 86118

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r86118 | file | 2007-10-17 11:39:27 -0500 (Wed, 17 Oct 2007) | 12 lines

Merged revisions 86117 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86117 | file | 2007-10-17 13:58:03 -0300 (Wed, 17 Oct 2007) | 4 lines

Whoops, forgot to remove the original sip_scheddestroy.
(closes issue ASTERISK-10555)
Reported by: vadim

........

------------------------------------------------------------------------