Summary:	ASTERISK-10542: [patch] Issues with threadstorage.c
Reporter:	snuffy (snuffy)	Labels:
Date Opened:	2007-10-16 08:33:28	Date Closed:	2007-10-29 20:26:24
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) new-patch.diff
Description:	This fixes a few issues with threadstorage not building, still one remaining error listed below. It compiles everything then throws this error about _ast_calloc() not being found. ****** STEPS TO REPRODUCE ****** [LD] abstract_jb.o acl.o adsistub.o aescrypt.o aeskey.o aestab.o alaw.o app.o ast_expr2.o ast_expr2f.o asterisk.o astmm.o astobj2.o audiohook.o autoservice.o callerid.o cdr.o channel.o chanvars.o cli.o config.o cryptostub.o db.o devicestate.o dial.o dns.o dnsmgr.o dsp.o enum.o event.o file.o fixedjitterbuf.o frame.o fskmodem.o http.o image.o indications.o io.o jitterbuf.o loader.o logger.o manager.o md5.o netsock.o pbx.o plc.o privacy.o rtp.o say.o sched.o sha1.o slinfactory.o srv.o stdtime/localtime.o strcompat.o tdd.o term.o threadstorage.o translate.o udptl.o ulaw.o utils.o editline/libedit.a db1-ast/libdb1.a minimime/libmmime.a -> asterisk threadstorage.o(.text+0xa4): In function `__ast_threadstorage_object_add': ../main/threadstorage.c:57: undefined reference to `_ast_calloc' collect2: ld returned 1 exit status make[1]: *** [asterisk] Error 1 make: *** [main] Error 2
Comments:	By: Digium Subversion (svnbot) 2007-10-16 08:59:16 Repository: asterisk Revision: 85818 U   branches/1.4/main/threadstorage.c ------------------------------------------------------------------------ r85818 | file | 2007-10-16 08:59:16 -0500 (Tue, 16 Oct 2007) | 6 lines Fix memory allocation issue in threadstorage. (closes issue ASTERISK-10542) Reported by: snuffy Patches:      new-patch.diff uploaded by snuffy (license 35) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-10-16 09:00:43 Repository: asterisk Revision: 85819 _U  trunk/ U   trunk/main/threadstorage.c ------------------------------------------------------------------------ r85819 | file | 2007-10-16 09:00:43 -0500 (Tue, 16 Oct 2007) | 14 lines Merged revisions 85818 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r85818 | file | 2007-10-16 11:19:39 -0300 (Tue, 16 Oct 2007) | 6 lines Fix memory allocation issue in threadstorage. (closes issue ASTERISK-10542) Reported by: snuffy Patches:      new-patch.diff uploaded by snuffy (license 35) ........ ------------------------------------------------------------------------ By: snuffy (snuffy) 2007-10-21 16:38:31 Leaving this as 'ast_calloc' the compilation fails at final linking threadstorage.o(.text+0xa4): In function `__ast_threadstorage_object_add': ../main/threadstorage.c:57: undefined reference to `_ast_calloc' collect2: ld returned 1 exit status make[1]: *** [asterisk] Error 1 make: *** [main] Error 2 To make it compile correctly I changed ast_calloc to just calloc it then successfully compiles I have been able to reproduce this error on centOS 4.4 and centOS 5 on both AMD and Intel chips By: Digium Subversion (svnbot) 2007-10-29 17:43:51 Repository: asterisk Revision: 87498 _U  trunk/utils/ U   trunk/utils/Makefile U   trunk/utils/hashtest2.c ------------------------------------------------------------------------ r87498 | kpfleming | 2007-10-29 17:43:50 -0500 (Mon, 29 Oct 2007) | 2 lines UGH... while trying to fix ASTERISK-10542, I found all kinds of cruft in this Makefile. It should all be gone now, and as a side effect hashtest2 now builds with --enable-dev-mode enabled without a host of errors ------------------------------------------------------------------------ By: Kevin P. Fleming (kpfleming) 2007-10-29 17:44:25 Please update to r87498 or newer, do a 'make clean', and try again. This should be fixed now. By: snuffy (snuffy) 2007-10-29 19:59:17 Yep this appears to work fine now, final linking works Can be closed By: Jason Parker (jparker) 2007-10-29 20:26:23 Fixed, per reporter.