[Home]

Summary:ASTERISK-10539: [PATCH] [sound] Add some functional to SayPosition in App_Queue
Reporter:Badalian Vyacheslav (slavon)Labels:
Date Opened:2007-10-16 01:11:26Date Closed:2008-04-30 14:25:52
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_q.diff
( 1) app_queue.diff
Description:Hello.

I write patch that add more functional to app_queue.


****** ADDITIONAL INFORMATION ******

After apply patch You get more options in queues:
///
announce-position = limit | more | yes | no ; default = yes
announce-position-limit = 60 ; default = 60
queue-morethan = queue-morethan ; default queue-morethan
///

if announce-position = yes then announce position will be announce
if announce-position = no then announce position will not be announce
if announce-position = limit then announce position will be announce if position <= "announce-position-limit"
if announce-position = more then announce position will be announce but if position > "announce-position-limit" we say "There are currently !more than! /announce-position-limit/ ..."
Comments:By: Badalian Vyacheslav (slavon) 2007-10-16 01:17:01

see also http://bugs.digium.com/view.php?id=8515
I get it idea and do it more functional...
By: Badalian Vyacheslav (slavon) 2007-10-16 01:34:15

Sorry...
announce-position-limit = 10 ; default = 10
+)
By: Mark Michelson (mmichelson) 2007-10-16 10:27:32

I like the idea behind this patch, and the code looks good. The only thing keeping me from committing this right now is that there is no queue-more-than sound in Asterisk currently. After we get this recorded, this will be committed.
By: Badalian Vyacheslav (slavon) 2007-11-02 04:07:00

i think easy add some functional to announce-time...

like
announce-time = limit | more | yes | no ; default = yes
announce-time-limit = 600 ; default = 600sec is 10 min
By: Badalian Vyacheslav (slavon) 2007-11-05 15:25:11.000-0600

putnopvut do you get recorded "queue-more-than"?
That you think for "announce-time"? Need to write patch?
By: Badalian Vyacheslav (slavon) 2007-12-27 05:11:46.000-0600

up
By: Jared Smith (jsmith) 2007-12-27 07:44:23.000-0600

Can we get a status update re: getting the sound recorded?
By: Badalian Vyacheslav (slavon) 2007-12-27 07:49:19.000-0600

I was thank that Asterisk team must record sound. It's wrong?
By: Mark Michelson (mmichelson) 2007-12-27 10:26:10.000-0600

slavon, you are correct. When this issue was first created, I sent a request to the developer in charge of getting sounds recorded to get the necessary sounds recorded but it has not been done yet. This issue is one of several that are open that could be closed if the sounds were recorded. I apologize that this has not been resolved more quickly.
By: Mark Michelson (mmichelson) 2008-02-13 14:09:29.000-0600

Assigned to Corydon76 since sound recording is what is holding this up.
By: Badalian Vyacheslav (slavon) 2008-03-06 09:53:24.000-0600

any updates? =)
By: Tilghman Lesher (tilghman) 2008-04-25 11:51:12

queue-quantity1 and queue-quantity2 are currently recorded for this purpose, which correspond to "Currently there are more than" and "callers waiting to speak with a representative".
By: Tilghman Lesher (tilghman) 2008-04-25 12:07:01

Patch no longer cleanly applies to trunk.
By: Badalian Vyacheslav (slavon) 2008-04-30 01:31:12

i repost patch for trunk...  variables named queue-quantity1 and queue-quantity2.
By: Digium Subversion (svnbot) 2008-04-30 14:25:15

Repository: asterisk
Revision: 114906

U   trunk/CHANGES
U   trunk/apps/app_queue.c
U   trunk/configs/queues.conf.sample

------------------------------------------------------------------------
r114906 | mmichelson | 2008-04-30 14:25:14 -0500 (Wed, 30 Apr 2008) | 12 lines

Adding new configuration options to app_queue. This adds two new values
to announce-position, "limit" and "more," as well as a new option,
announce-position-limit. For more information on the use of these options,
see CHANGES or configs/queues.conf.sample.

(closes issue ASTERISK-10539)
Reported by: slavon
Patches:
     app_q.diff uploaded by slavon (license 288)
Tested by: slavon, putnopvut


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114906
By: Digium Subversion (svnbot) 2008-04-30 14:25:52

Repository: asterisk
Revision: 114907

_U  branches/1.6.0/

------------------------------------------------------------------------
r114907 | mmichelson | 2008-04-30 14:25:51 -0500 (Wed, 30 Apr 2008) | 19 lines

Blocked revisions 114906 via svnmerge

........
r114906 | mmichelson | 2008-04-30 14:30:41 -0500 (Wed, 30 Apr 2008) | 12 lines

Adding new configuration options to app_queue. This adds two new values
to announce-position, "limit" and "more," as well as a new option,
announce-position-limit. For more information on the use of these options,
see CHANGES or configs/queues.conf.sample.

(closes issue ASTERISK-10539)
Reported by: slavon
Patches:
     app_q.diff uploaded by slavon (license 288)
Tested by: slavon, putnopvut


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114907