Summary:ASTERISK-10502: [patch] Provides(fix) make rpm functionality to Asterisk
Reporter:Daniel Hazelbaker (cabal95)Labels:
Date Opened:2007-10-11 13:10:33Date Closed:2011-06-07 14:03:21
Versions:Frequency of
Environment:Attachments:( 0) asterisk-1.4.11-rpm.patch
( 1) asterisk-1.4.13-rpm.patch
Description:This patch fixes the old make rpm functionality in Asterisk. It also replaces it with style that is much more akin to the Linux Kernel style of building an rpm from the source tree. Your options can be selected and then when you make rpm it will build those options for you and keep track of revision build #s.


Related to Zaptel bug 10950.  Also includes a patch that is in bug 10938 to fix make config as it is needed by this patch.
Comments:By: Jason Parker (jparker) 2007-10-25 17:46:22

If the mkspec file was taken from the Linux kernel, then we can't really accept this...

By: Daniel Hazelbaker (cabal95) 2007-10-26 10:30:05

Perhaps I should have updated the comments at the top of the mkspec file.  But this is what I did and you can tell me if it is still an issue.

I took the kernel mkspec file and the first thing I did was put in comments saying where I had originally got it from and who had modified it.  After that I quite litterly hacked away at it until it is almost completely a different work.  I believe that the only 2 lines that are still "based" upon the kernel mkspec file are the Version and Release lines (from which I kept the general syntax for stripping '-' out of the version number and running inline the mkrevision script).  So as it stands now it is pretty much an entirely new work.

If this is still an issue then I will rewrite the mkspec file from scratch and end up with pretty much an identical script anyway.  If it is not an issue then I will redo the comments at the top to relate that (at this point) the mkspec script concept was taken from the Linux kernel, which is probably a more accurate statement at this point.

Depending on your response I will also apply these changes to the addons and zaptel patches in a few days.  I need to get all the zaptel changes moved into the asterisk and addons patch and fix one last open complaint on the zaptel patch (which applies to asterisk and addons as well).

By: Tilghman Lesher (tilghman) 2008-01-17 20:10:11.000-0600

cabal95:  Unless you developed it from scratch, it's clearly a derivative work, and we cannot accept it unless all contributors sign licenses.

By: Daniel Hazelbaker (cabal95) 2008-01-24 16:08:31.000-0600

Alright, I will work on rewriting the mkspec file from scratch and try to at the same time work in better handling of SVN versioning.

By: jmls (jmls) 2008-02-17 13:00:21.000-0600

cabal95, how's it going ?

By: Joshua C. Colp (jcolp) 2008-06-04 08:42:54

cabal95: Any progress?

By: Tilghman Lesher (tilghman) 2008-06-19 17:57:20

Issue appears to be abandoned.  No reported progress in over 3 months.