[Home]

Summary:ASTERISK-10497: [patch] delete non-existant schedule
Reporter:Frederic LE FOLL (flefoll)Labels:
Date Opened:2007-10-11 01:29:21Date Closed:2007-10-11 10:08:40
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.c.br14.85280.xmit_reliable-patch
Description:chan_sip revision 79857 introduced several schedule cancelations before new schedule activations (SIP timeouts handling).

One of them seems useless in __sip_reliable_xmit() : the packet structure has just been allocated, so there can't be any schedule already activated (plus : the test is "retransid > -1" while the whole packet structure was 'memset' to 0).

I propose a patch to remove this call to ast_sched_del().
Comments:By: Digium Subversion (svnbot) 2007-10-11 10:05:46

Repository: asterisk
Revision: 85397

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r85397 | file | 2007-10-11 10:05:45 -0500 (Thu, 11 Oct 2007) | 6 lines

When creating a new packet don't try to stop retransmission of it. It was just allocated/created so it's impossible for it to have already been scheduled.
(closes issue ASTERISK-10497)
Reported by: flefoll
Patches:
     chan_sip.c.br14.85280.xmit_reliable-patch uploaded by flefoll (license 244)

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-10-11 10:08:40

Repository: asterisk
Revision: 85398

_U  trunk/

------------------------------------------------------------------------
r85398 | file | 2007-10-11 10:08:39 -0500 (Thu, 11 Oct 2007) | 13 lines

Blocked revisions 85397 via svnmerge

........
r85397 | file | 2007-10-11 12:26:20 -0300 (Thu, 11 Oct 2007) | 6 lines

When creating a new packet don't try to stop retransmission of it. It was just allocated/created so it's impossible for it to have already been scheduled.
(closes issue ASTERISK-10497)
Reported by: flefoll
Patches:
     chan_sip.c.br14.85280.xmit_reliable-patch uploaded by flefoll (license 244)

........

------------------------------------------------------------------------