[Home]

Summary:ASTERISK-10453: pulsedial=no setting is runtime changed in chan_zap.c so you can't simply disable pulse dialling
Reporter:arekm (arekm)Labels:
Date Opened:2007-10-05 01:34:37Date Closed:2011-06-07 14:08:01
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The problem is that pulsedial=no setting is ignored in zapata.conf. If pulse dialing is detected on the zap channel then chan_zap automaticly changes pulsedial to yes runtime.

The pulsedial option should be IMO changed to some tristate value: yes/no/auto to obey administrator whishes.

Relevant channels/chan_zap.c code:

       ast_log(LOG_DEBUG, "Got event %s(%d) on channel %d (index %d)\n", event2str(res), res, p->channel, index);

       if (res & (ZT_EVENT_PULSEDIGIT | ZT_EVENT_DTMFUP)) {
               p->pulsedial =  (res & ZT_EVENT_PULSEDIGIT) ? 1 : 0;

               ast_log(LOG_DEBUG, "Detected %sdigit '%c'\n", p->pulsedial ? "pulse ": "", res & 0xff);


****** ADDITIONAL INFORMATION ******

Of course it could be treated as "feature" not "bug" but IMO it's a bug to ignore config setting.
Comments:By: Tzafrir Cohen (tzafrir) 2007-10-06 04:10:47

The way I understand it, pulsedial is set from the user on FXO channels (where we need to dial) and automatically detected on FXS channels (where we detect digits).

In light of that, can you please be more specific in your bug description as to what you consider is incorrect?

Could you please provide a test case?

By: Jason Parker (jparker) 2007-11-02 15:13:41

Closing per comment from tzafrir.  Please reopen if you are able to provide the requested information.