Summary:	ASTERISK-10434: parkingcalls, by context with minim code change and not config changes.
Reporter:	german aracil boned (tecnoxarxa)	Labels:
Date Opened:	2007-10-02 18:05:29	Date Closed:	2008-02-14 17:08:34.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_features
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) res_features_parkingcalls_by_context.patch
Description:	I change very poor the code for get this feature. Now asterisk users have parkedcalls by context, simply and automatic. Without new config or change of the file features.conf I'm tested this and work property. No changes for features.conf only res_features.c With this little change, the parkedcalls get a new power with interest for all.
Comments:	By: Mitch Sharp (bluecrow76) 2007-12-17 16:29:15.000-0600 I have just added this feature to my 1.4.15 and so far so good!!!  Code has been moved from ast_park_call to park_call_full since the patch was written, but it appears to work.  Will be putting some more time into testing over the next few days. The extensions are not being removed from the dial plan after the call is returned, causing the "Whoa, failed to remove the extension!" messages. One thing I am looking into is setting a dial plan variable PARKCONTEXT to override the current context for flexibility. By: Vadim Berezniker (kryptolus) 2008-01-03 10:16:25.000-0600 there are some problems with your patch * you use strstr to match context which will match substrings * the if(pa) block after matching context is not needed * you return on error without unlocking By: Vadim Berezniker (kryptolus) 2008-01-03 10:59:18.000-0600 and also, you use the wrong context every time you try to remove an extension By: german aracil boned (tecnoxarxa) 2008-01-04 02:52:46.000-0600 First, Very thank to all I need make new patch with bug fix. By: yema (yem) 2008-01-14 09:50:18.000-0600 This is a very useful feature. Is it stable and working ? By: Jason Parker (jparker) 2008-01-16 13:58:10.000-0600 This patch also needs to be against svn trunk, rather than a branch. By: VladimirB (vladb) 2008-01-18 12:08:26.000-0600 Hi everyone, I did apply the patch to 1.4.17 and there some issues. 1. It was crashing instantly. Found that for some reason second channel was null in func call: res = park_call_full(chan, NULL, 0, NULL, orig_chan_name); Once we put it in it start working - res = park_call_full(chan, chan, 0, NULL, orig_chan_name); Is this an error ? 2 When call is unpacked, park slot counter is going up for  every next parked call. Don’t know why. We fixed for now by checking if parkinglot is free pa->parkinglot == NULL, set pa->offset = 0; And adjusting context variable for releasing parking lot: con = ast_context_find(parking_con);   to  con = ast_context_find(pu->context); Tecnoxarxa, may be you can update your patch with this fixes, It may give a good step ahead. By: Mark Michelson (mmichelson) 2008-02-14 17:08:32.000-0600 I am closing this issue for the following reasons: 1. This idea is a pretty much a subset of the multiple-parking lots issue (ASTERISK-5955). 2. No new patch has been uploaded since the original was uploaded two months ago. I encourage those of you interested in this patch to follow along on 6113, test and report back results there.