| Summary: | ASTERISK-10430: Adding one touch parking to app_queue | ||
| Reporter: | Mitch Sharp (bluecrow76) | Labels: | |
| Date Opened: | 2007-10-02 10:57:44 | Date Closed: | 2007-10-09 17:14:40 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_queue.patch ( 1) app_queue.v2.patch | |
| Description: | Basically just copied the lines out of app_dial.c that allows me to use one touch parking, as configured in features.conf, in app_queue. ****** ADDITIONAL INFORMATION ****** First added this to 1.4.5 and 1.4.11 on running customer servers. In 1.4 I also had to update res_features.c to allow unparked calls to be reparked using one touch. I noticed that these features are already available in the current svn trunk so I have not posted them, although I will have the patches posted at http://www.bluecrow.net/files/asterisk/patches | ||
| Comments: | By: Mark Michelson (mmichelson) 2007-10-04 17:08:05 Oops! Forgot to actually add the note before requesting feedback. This seems like a cool feature. By putting it on customer servers, can I take that to mean this has been tested? By: Mitch Sharp (bluecrow76) 2007-10-04 20:54:51 That would be a valid assumption! We tested it first at our office on 1.4.11 and then on a customer's server running 1.4.5. It's been four days now and no problems. We've tried it with IAX2, SIP and Zap trunks. There hasn't been a single instance of any weird behavior of any kind. By: Mitch Sharp (bluecrow76) 2007-10-04 21:00:52 The posted patch was created for SVN trunk. The tested code was on 1.4.11 and 1.4.5. I do not currently have any systems running SVN trunk to test it on, but the code involved doesn't look any different in SVN. The only thing that may be different with SVN is res_features.c. In the 1.4 branch I had to add the 'k' option to the channel as it came off park so that it would be capable of being reparked. Prior to the 't' option for transfer was the only feature configured on the picked up channel. It appears in SVN that that has been handled by updated code. It looks like it maps whatever features the parked channel originally had to the picked up channel, but this hasn't been tested yet. However, this is a separate issue than the actual patch to app_queue.c. By: Mitch Sharp (bluecrow76) 2007-10-08 15:03:01 Had a stray semicolon in the first patch. By: Darren Philips (dazza76) 2007-10-09 16:46:59 Works Well with SVN-branch-1.4-r84692M Daz By: Mark Michelson (mmichelson) 2007-10-09 17:11:20 All right. I'm about to commit this. Thanks for contributing, and thanks for testing! By: Digium Subversion (svnbot) 2007-10-09 17:14:40 Repository: asterisk Revision: 85177 U trunk/apps/app_queue.c ------------------------------------------------------------------------ r85177 | mmichelson | 2007-10-09 17:14:39 -0500 (Tue, 09 Oct 2007) | 5 lines Patch to add one-touch parking for queues. (closes issue ASTERISK-10430, reported and patched by bluecrow76) ------------------------------------------------------------------------ | ||