Summary:	ASTERISK-10416: [patch] Sort music on hold files list
Reporter:	James Golovich (jamesgolovich)	Labels:
Date Opened:	2007-09-30 23:38:22	Date Closed:	2007-10-02 09:47:39
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_musiconhold
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-mohsortalpha.diff.txt
Description:	Heres a patch to add "sort=alpha" option to musiconhold so that files will be sorted alphanumerically so the order they are played is predictable.  I used the "sort=" config name in case another sort method would be added in the future. This patch also adds "sort=random" which is the same as "random=yes".  Seems like this would be a more appropriate way of specifying random in the future.
Comments:	By: Digium Subversion (svnbot) 2007-10-01 09:24:47 Repository: asterisk Revision: 84168 U   trunk/configs/musiconhold.conf.sample U   trunk/res/res_musiconhold.c ------------------------------------------------------------------------ r84168 | russell | 2007-10-01 09:24:46 -0500 (Mon, 01 Oct 2007) | 8 lines Add a new option for files-based music on hold to ensure that the sort order of the files is alphabetical. (closes issue ASTERISK-10416) Reported by: jamesgolovich Patches:      asterisk-mohsortalpha.diff.txt uploaded by jamesgolovich (license 176) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-10-02 09:47:39 Repository: asterisk Revision: 84403 _U  team/group/v6/trunk/ U   team/group/v6/trunk/Makefile U   team/group/v6/trunk/Makefile.rules U   team/group/v6/trunk/apps/app_dial.c U   team/group/v6/trunk/apps/app_meetme.c U   team/group/v6/trunk/apps/app_minivm.c U   team/group/v6/trunk/channels/Makefile U   team/group/v6/trunk/channels/chan_agent.c U   team/group/v6/trunk/channels/chan_iax2.c U   team/group/v6/trunk/channels/chan_mgcp.c U   team/group/v6/trunk/channels/chan_misdn.c U   team/group/v6/trunk/channels/chan_sip.c U   team/group/v6/trunk/channels/chan_skinny.c U   team/group/v6/trunk/channels/iax2-parser.c U   team/group/v6/trunk/codecs/g722/Makefile U   team/group/v6/trunk/configs/musiconhold.conf.sample U   team/group/v6/trunk/include/asterisk/lock.h U   team/group/v6/trunk/main/asterisk.c U   team/group/v6/trunk/main/channel.c U   team/group/v6/trunk/main/cli.c U   team/group/v6/trunk/main/dnsmgr.c U   team/group/v6/trunk/main/frame.c U   team/group/v6/trunk/main/manager.c U   team/group/v6/trunk/main/rtp.c U   team/group/v6/trunk/main/say.c U   team/group/v6/trunk/main/utils.c U   team/group/v6/trunk/pbx/dundi-parser.c U   team/group/v6/trunk/pbx/pbx_ael.c U   team/group/v6/trunk/res/Makefile U   team/group/v6/trunk/res/ael/ael.tab.c U   team/group/v6/trunk/res/ael/ael.y U   team/group/v6/trunk/res/ael/pval.c U   team/group/v6/trunk/res/res_agi.c U   team/group/v6/trunk/res/res_config_odbc.c U   team/group/v6/trunk/res/res_musiconhold.c U   team/group/v6/trunk/utils/check_expr.c ------------------------------------------------------------------------ r84403 | simon.perreault | 2007-10-02 09:47:37 -0500 (Tue, 02 Oct 2007) | 278 lines Merged revisions 84159,84161-84162,84164-84165,84167-84169,84171-84174,84176,84207,84237,84272,84275,84300,84327,84329-84331,84368,84371 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r84159 | file | 2007-10-01 09:53:09 -0400 (Mon, 01 Oct 2007) | 12 lines Merged revisions 84158 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r84158 | file | 2007-10-01 10:49:36 -0300 (Mon, 01 Oct 2007) | 4 lines Only attempt early bridging if the options given to Dial() permit it. (closes issue ASTERISK-10422) Reported by: peekyb ........ ................ r84161 | file | 2007-10-01 09:59:13 -0400 (Mon, 01 Oct 2007) | 14 lines Merged revisions 84160 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r84160 | file | 2007-10-01 10:57:42 -0300 (Mon, 01 Oct 2007) | 6 lines Fix randomness. save_pos was being set to 0 initially instead of -1, causing it to jump to position 0 when moh started. (closes issue ASTERISK-10420) Reported by: jamesgolovich Patches:      asterisk-mohpos2.diff.txt uploaded by jamesgolovich (license 176) ........ ................ r84162 | file | 2007-10-01 10:02:26 -0400 (Mon, 01 Oct 2007) | 6 lines Don't register the dnsmgr refresh CLI command twice. (closes issue ASTERISK-10417) Reported by: jamesgolovich Patches:      asterisk-dnsmgrclireg.diff.txt uploaded by jamesgolovich (license 176) ................ r84164 | file | 2007-10-01 10:12:05 -0400 (Mon, 01 Oct 2007) | 11 lines Blocked revisions 84163 via svnmerge ........ r84163 | file | 2007-10-01 11:10:47 -0300 (Mon, 01 Oct 2007) | 4 lines Remove chan_usbradio config file from tree, it is not present in here. (closes issue ASTERISK-10403) Reported by: casper ........ ................ r84165 | file | 2007-10-01 10:21:06 -0400 (Mon, 01 Oct 2007) | 6 lines Add MP4 to part of the SDP code. (closes issue ASTERISK-10385) Reported by: ruikubo Patches:      chan_sip.patch uploaded by ruikubo (license 250) ................ r84167 | russell | 2007-10-01 10:27:02 -0400 (Mon, 01 Oct 2007) | 10 lines Merged revisions 84166 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r84166 | russell | 2007-10-01 09:24:49 -0500 (Mon, 01 Oct 2007) | 2 lines Simplify the CAN_EARLY_BRIDGE macro a bit. ........ ................ r84168 | russell | 2007-10-01 10:43:56 -0400 (Mon, 01 Oct 2007) | 8 lines Add a new option for files-based music on hold to ensure that the sort order of the files is alphabetical. (closes issue ASTERISK-10416) Reported by: jamesgolovich Patches:      asterisk-mohsortalpha.diff.txt uploaded by jamesgolovich (license 176) ................ r84169 | russell | 2007-10-01 10:55:10 -0400 (Mon, 01 Oct 2007) | 7 lines Don't set the full command string until after verifying that there is not another CLI command with the same command text registered.  This prevents a crash if someone accidentally calls ast_cli_register()  on the same CLI command data twice.  This also fixes a small bug where the helpers list would get unlocked without being locked if building the full command failed. (closes issue ASTERISK-10419, reported by jamesgolovich, patched by me) ................ r84171 | russell | 2007-10-01 11:06:14 -0400 (Mon, 01 Oct 2007) | 14 lines The trunk version of this patch also includes a couple more small clean fixes from IgorG. Merged revisions 84170 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r84170 | russell | 2007-10-01 10:00:56 -0500 (Mon, 01 Oct 2007) | 3 lines Remove another file in "make clean". (closes issue ASTERISK-10379, paravoid) ........ ................ r84172 | russell | 2007-10-01 11:17:15 -0400 (Mon, 01 Oct 2007) | 7 lines Simplify code by using the -= and