Summary:ASTERISK-10415: [patch] remove extra logging from ast_add_extension2
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2007-09-30 14:27:21Date Closed:2007-10-01 10:19:04
Versions:Frequency of
Environment:Attachments:( 0) addext.patch
Description:ast_add_extension2 logs the fact it added extension twice - once with ast_debug and second time with ast_verb. I believe there is no real need in doubling this information.


The patch removes ast_verb leaving only ast_debug logging. Also, extra "if (option_debug)" check is removed because this check is done by ast_debug anyway.
Comments:By: Tilghman Lesher (tilghman) 2007-09-30 18:55:02

I'm not sure I agree.  Debug logging is only ever supposed to be turned on when you're debugging an issue, and verbose is not meant to go to the log -- it's meant to go to the console.

There are frequent cases where you'd want to see the verbose output, but not the debug output, and for that reason (differing purposes), I don't think this patch should be applied.

By: Dmitry Andrianov (dimas) 2007-10-01 03:23:42

well, you can do the opposite - leave ast_verb in place and remove ast_debug. But what is the reason in having BOTH?

By: Tilghman Lesher (tilghman) 2007-10-01 10:19:04

I think I adequately explained the position in the first note.