Summary: | ASTERISK-10386: Deffect in Attended Transfer code | ||
Reporter: | Volnikov Ivan (ivan) | Labels: | |
Date Opened: | 2007-09-25 08:52:27 | Date Closed: | 2007-10-02 13:41:02 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Resources/res_features |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) ast_1_4_11_svn_patch_res_features_transfer.diff | |
Description: | Function builtin_atxfer <res_features.c> include code (last SVN version): ... 819 if (check_compat(transferer, newchan)) 820 return -1; ... 834 if (check_compat(transferee, newchan)) 835 return -1; ... I think that include deffect like not correct free alloced resources. ****** ADDITIONAL INFORMATION ****** Needs call finishup(transferee); before return value. Patch applied. | ||
Comments: | By: Jason Parker (jparker) 2007-10-02 13:28:15 I assume you meant to finishup(transferer) on the first one? By: Jason Parker (jparker) 2007-10-02 13:31:02 my mistake, you're right - you do mean transferee By: Digium Subversion (svnbot) 2007-10-02 13:41:02 Repository: asterisk Revision: 84432 _U trunk/ U trunk/res/res_features.c ------------------------------------------------------------------------ r84432 | qwell | 2007-10-02 13:41:01 -0500 (Tue, 02 Oct 2007) | 13 lines Merged revisions 84410 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue ASTERISK-10386) ........ r84410 | qwell | 2007-10-02 13:52:55 -0500 (Tue, 02 Oct 2007) | 4 lines Finish up on transferee channel before return on failure. Issue 10821, patch by Ivan ........ ------------------------------------------------------------------------ |