Summary: | ASTERISK-10372: [patch] Allow ParkedCall to pickup the first parked call | ||
Reporter: | outtolunc (outtolunc) | Labels: | |
Date Opened: | 2007-09-22 18:17:21 | Date Closed: | 2007-11-13 14:28:11.000-0600 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Resources/res_features |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) res_features-parkedcall-any.diff ( 1) res_features-parkedcall-any.diff2 ( 2) res_features-parkedcall-any.diff3 ( 3) res_features-parkedcall-any.diff4 | |
Description: | ParkedCall allowed you to specify the parked extension to pickup that parked call. But there was not a way to pickup one of those parked extensions unless you knew the extension. It would be simple to loop around till you got one, but since the code is already looking at all of the parkinglot list, this patch just makes it so simple to grab the first one and go. usage: ParkedCall(700) Since the call parking starts at 701, i figured using 700 was a simplistic approach, and least intrusive to the code. ****** ADDITIONAL INFORMATION ****** Disclaimer on file. | ||
Comments: | By: outtolunc (outtolunc) 2007-09-22 18:22:09 file diff backward <G> oopsie By: outtolunc (outtolunc) 2007-09-22 18:36:07 I suppose it helps if it is documented. By: Clod Patry (junky) 2007-09-22 19:32:05 i refuse that patch, since the 700 can be customized in features.conf via: parkext => 700 so hard-coding this would be bad. By: outtolunc (outtolunc) 2007-09-23 11:27:33 this is true, i have never heard of anyone changing the parkext => 700 ; What extension to dial to park parkpos => 701-704 ; What extensions to park calls on. features.conf setting, but 'it could happen' <G> the issue i ran into, though i didn't look long, was the lack of me finding a var to reference which contained the number from the parkext above. i suppose we could add yet another. i will look around some more and see what else i twist. By: outtolunc (outtolunc) 2007-09-23 11:33:14 nevermind,i must have been blind last night.. new diff after i get some coffee. By: outtolunc (outtolunc) 2007-09-23 12:06:11 not really sure why last night i was so focused on looking for a global var that contained the parking exten, but sorry for the wasted time. ok, current patch will use the current parking extension. By: Digium Subversion (svnbot) 2007-11-13 14:28:11.000-0600 Repository: asterisk Revision: 89250 U trunk/CHANGES U trunk/res/res_features.c ------------------------------------------------------------------------ r89250 | russell | 2007-11-13 14:28:09 -0600 (Tue, 13 Nov 2007) | 9 lines Update the ParkedCall application to grab the first available parked call if no parked extension is provided as an argument. (closes issue ASTERISK-10372) Reported by: outtolunc Patches: res_features-parkedcall-any.diff4 uploaded by outtolunc (license 237) - modified by me to work a bit differently ... ------------------------------------------------------------------------ |