Summary: | ASTERISK-10361: for loops broken | ||
Reporter: | Luke-Jr (luke-jr) | Labels: | |
Date Opened: | 2007-09-21 04:59:30 | Date Closed: | 2007-09-22 14:35:15 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | PBX/pbx_ael |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | Currently, this line: for (&iterator(${TRY},A); "${A}" != ""; &iterate(A)) { Is being compiled to include: 13. Set( &iterate(A)) [pbx_ael] The 3rd element should not be wrapped in Set! | ||
Comments: | By: Luke-Jr (luke-jr) 2007-09-22 01:02:50 6. Macro(iterator|${TRY}|A) 7. GotoIf($[ "${A}" != "" ]?8:14) ... 12. Macro(iterate|A) 13. Goto(7) By: Luke-Jr (luke-jr) 2007-09-22 01:03:33 Last comment is what the 'for' compiled to in 1.2 By: Digium Subversion (svnbot) 2007-09-22 11:23:07 Repository: asterisk Revision: 83558 ------------------------------------------------------------------------ r83558 | murf | 2007-09-22 11:23:07 -0500 (Sat, 22 Sep 2007) | 1 line This closes issue ASTERISK-10361 -- the 3rd arg in the for statement is now wrapped in Set() only if there's an '=' in that string. Otherwise, if it begins with '&', then a Macro call is generated; otherwise it is made into an app call. A bit more accomodating, keeps the new guys happy, and the guys with ael-1 code should be happy, too ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-22 12:20:42 Repository: asterisk Revision: 83575 ------------------------------------------------------------------------ r83575 | murf | 2007-09-22 12:20:42 -0500 (Sat, 22 Sep 2007) | 9 lines Merged revisions 83558 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83558 | murf | 2007-09-22 10:41:43 -0600 (Sat, 22 Sep 2007) | 1 line This closes issue ASTERISK-10361 -- the 3rd arg in the for statement is now wrapped in Set() only if there's an '=' in that string. Otherwise, if it begins with '&', then a Macro call is generated; otherwise it is made into an app call. A bit more accomodating, keeps the new guys happy, and the guys with ael-1 code should be happy, too ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-22 14:20:21 Repository: asterisk Revision: 83589 ------------------------------------------------------------------------ r83589 | murf | 2007-09-22 14:20:20 -0500 (Sat, 22 Sep 2007) | 1 line This closes issue ASTERISK-10361 -- The exact same fixes are made here for the first arg in the for(arg1; arg2; arg3) {} statement, as were done for the 3rd arg. It can now be an assignment that will embedded in a Set() app, or a macro call, or an app call. ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-22 14:35:15 Repository: asterisk Revision: 83590 ------------------------------------------------------------------------ r83590 | murf | 2007-09-22 14:35:15 -0500 (Sat, 22 Sep 2007) | 9 lines Merged revisions 83589 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83589 | murf | 2007-09-22 13:39:16 -0600 (Sat, 22 Sep 2007) | 1 line This closes issue ASTERISK-10361 -- The exact same fixes are made here for the first arg in the for(arg1; arg2; arg3) {} statement, as were done for the 3rd arg. It can now be an assignment that will embedded in a Set() app, or a macro call, or an app call. ........ ------------------------------------------------------------------------ |