Summary:ASTERISK-10358: Allow assigning client status and priority
Reporter:Luke-Jr (luke-jr)Labels:
Date Opened:2007-09-21 04:05:29Date Closed:2007-10-07 11:09:00
Versions:Frequency of
Environment:Attachments:( 0) asterisk-1.4.11-jabber-priority.patch
( 1) patch
Description:The current res_jabber hard codes the client's status and priority. This makes it impractical to have a ghost Asterisk connection for intercepting only GTalk/Jingle calls. Changing these variables should be possible from at least the configuration file.


I have a patch that adds these settings to the config file.
Comments:By: phsultan (phsultan) 2007-09-21 05:46:47

We need you to send a disclaimer before reading your patch, thanks!

By: Luke-Jr (luke-jr) 2007-09-21 14:03:32

All my Asterisk patches are licensed in the public domain, which is inclusive of your disclaimer.

patch (5,124 bytes) 09-21-07 04:08 [License PENDING]

By: phsultan (phsultan) 2007-09-26 13:02:58

Looks nice, thanks for updating the documentation too. Since this is a new feature, it'll be committed to SVN trunk, can you provide a patch that applies to the SVN trunk rather than the 1.4 branch?

By: Luke-Jr (luke-jr) 2007-09-26 13:07:38

Is it really a new feature if it fixes usability bugs? ;)

By: phsultan (phsultan) 2007-09-27 04:15:19

Well, even if I understand your point, your patch makes two new configuration options available to the Asterisk admin, for two optional elements in the spec (<show/> and <priority/> in RFC 3921).

So I think those modifications better fit in the trunk, but still, I remain open to discussion for that :)

By: Jason Parker (jparker) 2007-10-02 13:11:20

These would be new features.  I doubt I could be convinced otherwise.

By: Luke-Jr (luke-jr) 2007-10-02 18:32:11

Then quite frankly, 1.4 shouldn't claim Jabber support if its subset is too small to do anything practical with it.

By: Digium Subversion (svnbot) 2007-10-07 11:09:00

Repository: asterisk
Revision: 84939

U   trunk/configs/jabber.conf.sample
U   trunk/include/asterisk/jabber.h
U   trunk/res/res_jabber.c

r84939 | phsultan | 2007-10-07 11:08:59 -0500 (Sun, 07 Oct 2007) | 3 lines

Make the status and priority configurable.

Closes issue ASTERISK-10358, patch by Luke-Jr, thanks!