[Home]

Summary:ASTERISK-10349: [patch] Portability fixes for openWRT
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2007-09-20 18:30:17Date Closed:2007-09-21 09:07:32
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20070920__for_capouch.diff.txt
Description:changes prompted by an email from Brian Capouch on the -dev mailing list.
Comments:By: capouch (capouch) 2007-09-21 00:04:26

The patch applied cleanly to a fresh checkout of trunk.

Still no joy, however, in terms of the "l" model functions (output curtailed after representative sample):

../main/ast_expr2.y: In function 'op_func':
../main/ast_expr2.y:730: warning: implicit declaration of function 'cosl'
../main/ast_expr2.y:730: warning: incompatible implicit declaration of built-in function 'cosl'
../main/ast_expr2.y:739: warning: implicit declaration of function 'sinl'
../main/ast_expr2.y:739: warning: incompatible implicit declaration of built-in function 'sinl'
../main/ast_expr2.y:748: warning: implicit declaration of function 'tanl'
../main/ast_expr2.y:748: warning: incompatible implicit declaration of built-in function 'tanl'


However, if I patch ast_expr2.c to #undef __USE_ISOC99 I no longer get the errors on round() and trunc(), so we have indeed solved that one!

There is a cryptic comment, by Murf, in the ast_expr2.c source code in the vicinity of the ISO99 stuff that leads me to think that the conditionals there on that #define may not be fully cooked.
By: Digium Subversion (svnbot) 2007-09-21 09:07:32

Repository: asterisk
Revision: 83431

------------------------------------------------------------------------
r83431 | tilghman | 2007-09-21 09:07:31 -0500 (Fri, 21 Sep 2007) | 2 lines

Check for the presence of trunc and round, and make the ISOC99 detection a little more sane (closes issue ASTERISK-10349)

------------------------------------------------------------------------