Summary: | ASTERISK-10342: [patch] chan_sip may retransmit a SIP message after 2ms only | ||
Reporter: | Frederic LE FOLL (flefoll) | Labels: | |
Date Opened: | 2007-09-20 07:50:44 | Date Closed: | 2007-09-21 07:00:48 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) chan_sip.c.br14.83070.retrans-patch ( 1) chan_sip.c.trunk.83071.retrans-patch | |
Description: | When qualify option is activated in sip.conf, chan_sip uses RTT (Round-Trip Time) measured with OPTIONS messages to adjust timer T1, where T1 is the basic delay for SIP retransmission mechanism. This occurs in two functions. - create_addr_from_peer() : this one checks measured RTT against a minimum value (it can be defined through t1min in sip.conf, or defaults to 100 ms). - check_user_full() : this one makes no control ! As a consequence, if last RTT was 1 ms, T1 is set to 1 ms and first retransmit (SIP Timer A) starts after 2 ms, which is much too short. I will propose a patch for trunk and for branch 1.4 | ||
Comments: | By: Digium Subversion (svnbot) 2007-09-20 11:06:43 Repository: asterisk Revision: 83232 ------------------------------------------------------------------------ r83232 | file | 2007-09-20 11:06:42 -0500 (Thu, 20 Sep 2007) | 7 lines Make sure the minimum T1 timer value is obeyed in all cases. (closes issue ASTERISK-10342) Reported by: flefoll Patches: chan_sip.c.trunk.83071.retrans-patch uploaded by flefoll (license 244) chan_sip.c.br14.83070.retrans-patch uploaded by flefoll (license 244) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-20 11:09:10 Repository: asterisk Revision: 83234 ------------------------------------------------------------------------ r83234 | file | 2007-09-20 11:09:09 -0500 (Thu, 20 Sep 2007) | 15 lines Merged revisions 83232 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83232 | file | 2007-09-20 13:25:30 -0300 (Thu, 20 Sep 2007) | 7 lines Make sure the minimum T1 timer value is obeyed in all cases. (closes issue ASTERISK-10342) Reported by: flefoll Patches: chan_sip.c.trunk.83071.retrans-patch uploaded by flefoll (license 244) chan_sip.c.br14.83070.retrans-patch uploaded by flefoll (license 244) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-21 07:00:48 Repository: asterisk Revision: 83399 ------------------------------------------------------------------------ r83399 | simon.perreault | 2007-09-21 07:00:43 -0500 (Fri, 21 Sep 2007) | 152 lines Merged revisions 83229,83231,83233-83234,83251,83278,83293-83298,83317,83349-83351,83381 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r83229 | file | 2007-09-20 12:10:57 -0400 (Thu, 20 Sep 2007) | 2 lines Fix memory leaks in pbx_dundi, cdr_pgsql, and the configuration file parser. ................ r83231 | file | 2007-09-20 12:19:45 -0400 (Thu, 20 Sep 2007) | 15 lines Merged revisions 83230 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83230 | file | 2007-09-20 13:17:24 -0300 (Thu, 20 Sep 2007) | 7 lines Fix a minor spelling error. (closes issue ASTERISK-10343) Reported by: flefoll Patches: chan_sip.c.trunk.83071.inita-patch uploaded by flefoll (license 244) chan_sip.c.br14.83070.inita-patch uploaded by flefoll (license 244) ........ ................ r83233 | russell | 2007-09-20 12:27:07 -0400 (Thu, 20 Sep 2007) | 3 lines Don't start the event processing thread until after forking. (reported by Simon on the -dev list, thanks!) ................ r83234 | file | 2007-09-20 12:28:00 -0400 (Thu, 20 Sep 2007) | 15 lines Merged revisions 83232 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83232 | file | 2007-09-20 13:25:30 -0300 (Thu, 20 Sep 2007) | 7 lines Make sure the minimum T1 timer value is obeyed in all cases. (closes issue ASTERISK-10342) Reported by: flefoll Patches: chan_sip.c.trunk.83071.retrans-patch uploaded by flefoll (license 244) chan_sip.c.br14.83070.retrans-patch uploaded by flefoll (license 244) ........ ................ r83251 | qwell | 2007-09-20 13:10:14 -0400 (Thu, 20 Sep 2007) | 16 lines Merged revisions 83246 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83246 | qwell | 2007-09-20 12:09:14 -0500 (Thu, 20 Sep 2007) | 8 lines If # is pressed after dialing an extension in DISA, stop trying to collect more digits. (closes issue ASTERISK-10329) Reported by: atis Patches: app_disa.c.branch.patch uploaded by atis (license 242) app_disa.c.trunk.patch uploaded by atis (license 242) ........ ................ r83278 | qwell | 2007-09-20 15:05:16 -0400 (Thu, 20 Sep 2007) | 1 line Fix a trivial typo, to test our new commit bot ................ r83293 | russell | 2007-09-20 15:11:31 -0400 (Thu, 20 Sep 2007) | 1 line trivial formatting change ................ r83294 | russell | 2007-09-20 15:17:16 -0400 (Thu, 20 Sep 2007) | 1 line fix spelling in a comment ................ r83295 | russell | 2007-09-20 15:22:10 -0400 (Thu, 20 Sep 2007) | 1 line minor grammar fix ................ r83296 | russell | 2007-09-20 15:32:18 -0400 (Thu, 20 Sep 2007) | 1 line minor spelling fixes in a comment ................ r83297 | russell | 2007-09-20 15:42:33 -0400 (Thu, 20 Sep 2007) | 1 line trivial formatting change ................ r83298 | russell | 2007-09-20 15:45:00 -0400 (Thu, 20 Sep 2007) | 1 line trivial formatting change ................ r83317 | russell | 2007-09-20 17:02:17 -0400 (Thu, 20 Sep 2007) | 11 lines Merged revisions 83316 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83316 | russell | 2007-09-20 16:01:20 -0500 (Thu, 20 Sep 2007) | 3 lines Change safe_asterisk to explicitly ask for /bin/bash, as it uses bashisms. (closes issue ASTERISK-10345, reported by culrich) ........ ................ r83349 | russell | 2007-09-20 17:17:39 -0400 (Thu, 20 Sep 2007) | 12 lines Merged revisions 83348 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83348 | russell | 2007-09-20 16:16:48 -0500 (Thu, 20 Sep 2007) | 4 lines When daemonizing, don't change working directory to "/". It makes it not be able to do a core dump when not running as uid=root. (closes issue ASTERISK-10340, xrg) ........ ................ r83350 | mmichelson | 2007-09-20 17:21:28 -0400 (Thu, 20 Sep 2007) | 3 lines Merging changes from queue_refcount_trunk into trunk. Refcounted queues now in place. ................ r83351 | mmichelson | 2007-09-20 17:37:28 -0400 (Thu, 20 Sep 2007) | 4 lines Oops. Getting rid of svnmerge-integrated and automerge stuff ................ r83381 | qwell | 2007-09-20 19:14:30 -0400 (Thu, 20 Sep 2007) | 8 lines More NEW_CLI conversions. (issue ASTERISK-10302) Patches: app_playback.c.patch uploaded by moy (license 222) app_minivm.c.patch uploaded by eliel (license 64) astmm.c.patch uploaded by eliel (license 64) ................ ------------------------------------------------------------------------ |