Summary:	ASTERISK-10336: [patch] incorrect CDR(lastapp) when monitor-type=MixMonitor
Reporter:	Alexandre Snarskii (snar)	Labels:
Date Opened:	2007-09-19 06:13:45	Date Closed:	2007-09-19 08:31:00
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app-queue-mixmonitor.patch
Description:	When monitor-type set to MixMonitor, MixMonitor and it's argument logged to cdr's as lastapp and lastdata. When monitor-type set to Monitor, these fields are Queue and queuename, and, I suppose, the latter behaviour is correct. ****** ADDITIONAL INFORMATION ****** app_queue.c calls MixMonitor using pbx_exec(..), and pbx_exec updates lastapp and lastdata fields in cdr with called application and it's data. Patch is about trivial -  app_queue should lock chan->cdr before calling pbx_exec and unlock it after.
Comments:	By: Digium Subversion (svnbot) 2007-09-19 08:29:15 Repository: asterisk Revision: 83074 ------------------------------------------------------------------------ r83074 | file | 2007-09-19 08:29:13 -0500 (Wed, 19 Sep 2007) | 6 lines Protect the CDR record from modification by pbx_exec so that the application data contains the Queue data. (closes issue ASTERISK-10336) Reported by: snar Patches:      app-queue-mixmonitor.patch uploaded by snar (license 245) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-19 08:31:00 Repository: asterisk Revision: 83075 ------------------------------------------------------------------------ r83075 | file | 2007-09-19 08:30:59 -0500 (Wed, 19 Sep 2007) | 14 lines Merged revisions 83074 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83074 | file | 2007-09-19 10:47:59 -0300 (Wed, 19 Sep 2007) | 6 lines Protect the CDR record from modification by pbx_exec so that the application data contains the Queue data. (closes issue ASTERISK-10336) Reported by: snar Patches:      app-queue-mixmonitor.patch uploaded by snar (license 245) ........ ------------------------------------------------------------------------