[Home]

Summary:ASTERISK-10301: [patch] Convert func_odbc to use SQLExecDirect() for speed
Reporter:Matthew Nicholson (mnicholson)Labels:
Date Opened:2007-09-14 11:48:08Date Closed:2008-01-18 00:56:06.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Functions/func_odbc
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) func-odbc-direct-execute1.diff
Description:This patch converts func_odbc to use SQLExecDirect() instead of SQLPrepare() then SQLExecute().  This patch depends on but 10722.  See bug 10722 for the reasoning behind this change.
Comments:By: Tilghman Lesher (tilghman) 2007-09-20 16:20:39

I'm interested in this, I'd just like to have it tested on a few more database backends than just MS SQL Server.
By: Matthew Nicholson (mnicholson) 2007-09-26 13:53:15

Should the status be changed to "ready for testing" then?
By: Private Name (falves11) 2008-01-09 07:42:00.000-0600

I will put in production if and stress test it, if the patch is ready for current version of Trunk. My simulator environment coupled with the Easysoft driver can test it to the limit.
By: Private Name (falves11) 2008-01-09 17:53:33.000-0600

THIS iS FANTASTIC!!!!
I recommend this patch to be saved in trunk right away. However, it begs for a similar modification to cdr_odbc, since every call saved to the databas uses 3 network calls versus one.

I tested the code with hundreds of simultaneus call attempts and it works.
By: Private Name (falves11) 2008-01-12 08:36:10.000-0600

I hereby request that this patch be committed, for it really helps lowering the stress on the system in a very high load scenario. Also, we need to do the same for cdr_odbc, or rewrite cdr_tds, which does not compile with the latest version of freetds. Either or. SQLExecDirect()  is the way to to.
By: Digium Subversion (svnbot) 2008-01-18 00:56:06.000-0600

Repository: asterisk
Revision: 99018

U   trunk/funcs/func_odbc.c

------------------------------------------------------------------------
r99018 | tilghman | 2008-01-18 00:56:05 -0600 (Fri, 18 Jan 2008) | 7 lines

Convert func_odbc to use SQLExecDirect for speed
(closes issue ASTERISK-10301)
Reported by: mnicholson
Patches:
      func-odbc-direct-execute1.diff uploaded by mnicholson (license 96)
Tested by: Corydon76, mnicholson, falves11

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=99018