Summary:	ASTERISK-10298: [patch] Code for USERUSERINFO support may create a global variable instead of a channel variable
Reporter:	Frederic LE FOLL (flefoll)	Labels:
Date Opened:	2007-09-14 07:21:11	Date Closed:	2007-09-14 12:32:43
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_zap
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_zap.c.80501-patch ( 1) chan_zap.c.82329-patch
Description:	When SUPPORT_USERUSER is defined, pri_dchannel() may create a global USERUSERINFO variable instead of a channel variable upon reception of PRI_EVENT_HANGUP : when pbx_builtin_setvar_helper() is called, first parameter pri->pvts[chanpos]->owner may be null (maybe it event always is ?). ****** ADDITIONAL INFORMATION ****** I propose a patch that tests pri->pvts[chanpos]->owner before calling pbx_builtin_setvar_helper(). There may be a better fix, by using another source to retrieve the channel id, or even by removing this call (isn't it too late anyway to set a channel variable ?).
Comments:	By: Frederic LE FOLL (flefoll) 2007-09-14 07:25:43 chan_zap.c.82329-patch is for SVN trunk chan_zap.c.80501-patch is for SVN branch 1.4 By: Digium Subversion (svnbot) 2007-09-14 12:29:24 Repository: asterisk Revision: 82394 ------------------------------------------------------------------------ r82394 | qwell | 2007-09-14 12:29:24 -0500 (Fri, 14 Sep 2007) | 5 lines If a channel does not have an owner, do not try to set a channel variable. This will end up making the channel variable global, which is not right. Closes issue ASTERISK-10298, patch by flefoll. ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-14 12:32:43 Repository: asterisk Revision: 82395 ------------------------------------------------------------------------ r82395 | qwell | 2007-09-14 12:32:42 -0500 (Fri, 14 Sep 2007) | 13 lines Merged revisions 82394 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r82394 | qwell | 2007-09-14 12:48:05 -0500 (Fri, 14 Sep 2007) | 5 lines If a channel does not have an owner, do not try to set a channel variable. This will end up making the channel variable global, which is not right. Closes issue ASTERISK-10298, patch by flefoll. ........ ------------------------------------------------------------------------