Summary:ASTERISK-10221: Configuration file inclusion broken on reload
Reporter:Igor Goncharovsky (igorg)Labels:
Date Opened:2007-09-02 22:24:52Date Closed:2007-09-03 12:43:40
Versions:Frequency of
Environment:Attachments:( 0) reload_broken_log.txt
Description:I latest SVN trunk i have this scenario:
0. I have main sip.conf with included files with templates and trunks.
1. I have start asterisk first time: all files loaded and all trunk visible with `sip show peers`
2. I have reload chan_sip.so: module reloaded without reloading included files (they remain unchanged) and now i haven't seen any trunk in `sip show peers`
3. I have change file with trunk definition and reload: asterisk load new sip_trunk.conf and show warning about that template `t_sipgate` does not exists. No seep peers appear at all.

I think old behavior was broken when introduced not loading unchanged configuration files.
Comments:By: Tilghman Lesher (tilghman) 2007-09-02 22:45:10

Please try this patch and report back if it fixes this issue.

By: Igor Goncharovsky (igorg) 2007-09-02 23:16:32

No, it is not.

I haven't using users.conf, this is default. Also some days ago I have update my sip.conf to latest from trunk, but it must not make any problem.

By: Tilghman Lesher (tilghman) 2007-09-03 09:36:00

Okay, I can't reproduce this at all.  I have tried every variation of a reload command that I can think of and my peers never disappear.

Maybe you should upload your sip.conf ?

By: James Golovich (jamesgolovich) 2007-09-03 11:52:25

Don't have time to look into fixing this till later tonight (if needed), but you can reproduce it by adding a #include in the sip.conf and stick your test peer in it.

Once your sure its loaded and visible in your peers, a 'module reload chan_sip.so' will remove it.

By: Tilghman Lesher (tilghman) 2007-09-03 12:42:28

Aha!  Thank you for the repeatable case.

By: Digium Subversion (svnbot) 2007-09-03 12:43:40

Repository: asterisk
Revision: 81432

r81432 | tilghman | 2007-09-03 12:43:38 -0500 (Mon, 03 Sep 2007) | 2 lines

Once we get past the file checks, we're loading, so clear the FILEUNCHANGED flag (fixes #include) (closes issue ASTERISK-10221)