Summary:	ASTERISK-10214: [patch] menuselect: add page up/down support and visually indicate long category lists
Reporter:	Sean Bright (seanbright)	Labels:
Date Opened:	2007-08-31 13:32:44	Date Closed:	2007-09-04 13:35:24
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) menuselect_curses.c.09012007.patch ( 1) menuselect_curses.c.patch ( 2) menuselect-navi-10622.diff
Description:	Adds '...' to a list of categories in menuselect that is too long to fit on the menu (and '...' to the top once you've scrolled).  Also adds page up and page down support. ****** ADDITIONAL INFORMATION ****** Added it against Asterisk since I didn't see a project listing for menuselect.
Comments:	By: Jason Parker (jparker) 2007-08-31 13:53:04 Nice. Small bug I found though while testing.  If you press pgdn while on item 1, your cursor ends up on a "..." line.  I assume the same is true for pgup, if the last item in the list is at the location where the "..." line would be. Also, perhaps instead of "..." it could be "^^^" and "vvv"?  Something like that, to indicate direction a little better. By: Sean Bright (seanbright) 2007-08-31 13:57:58 I changed to ^^^ and vvv locally, but I can't reproduce the other issue.  What category are you looking at and what is the size of your terminal? By: Sean Bright (seanbright) 2007-09-01 11:24:07 OK.  I removed the scroll up indication (since that will be obvious once you've scrolled down (not to mention the numbers will start with something > 1)) and changed the scroll down indication to "... More ..." which is think looks pretty good.  Fixed the page up and page down and now will page by either PAGE_OFFSET (which is 10) or by the number of visible items if the number of displayed items is < 10. By: Jason Parker (jparker) 2007-09-04 12:30:52 Looks good, except we may want pgup/pgdown on the main menu as well. New patch uploaded to support home/end keys on main/sub menus. :) By: Digium Subversion (svnbot) 2007-09-04 13:33:31 Repository: menuselect Revision: 206 ------------------------------------------------------------------------ r206 | russell | 2007-09-04 13:33:30 -0500 (Tue, 04 Sep 2007) | 12 lines (closes issue ASTERISK-10214) Reported by: seanbright Patches:      menuselect_curses.c.09012007.patch uploaded by seanbright (license 71)  menuselect-navi-10622.diff uploaded by qwell (license 4) Tested by: qwell, seanbright Add some cool new display features to the curses frontend for menuselect. * Add support for Page Up/Down keys in category menus * Add support for Home/End keys in all menus * Add "... More ..." at the bottom of a menu when there is more to see ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-09-04 13:34:27 Repository: menuselect Revision: 207 ------------------------------------------------------------------------ r207 | russell | 2007-09-04 13:34:26 -0500 (Tue, 04 Sep 2007) | 20 lines Merged revisions 206 via svnmerge from https://origsvn.digium.com/svn/menuselect/branches/1.0 ........ r206 | russell | 2007-09-04 13:51:53 -0500 (Tue, 04 Sep 2007) | 12 lines (closes issue ASTERISK-10214) Reported by: seanbright Patches:      menuselect_curses.c.09012007.patch uploaded by seanbright (license 71)  menuselect-navi-10622.diff uploaded by qwell (license 4) Tested by: qwell, seanbright Add some cool new display features to the curses frontend for menuselect. * Add support for Page Up/Down keys in category menus * Add support for Home/End keys in all menus * Add "... More ..." at the bottom of a menu when there is more to see ........ ------------------------------------------------------------------------ By: Russell Bryant (russell) 2007-09-04 13:35:24 Nice job, guys.  I like it!  :)