[Home]

Summary:ASTERISK-10206: [patch] DNS SRV lookup behaviour is incorrect in some cases
Reporter:John Riordan (john)Labels:
Date Opened:2007-08-30 12:43:03Date Closed:2007-09-04 07:53:26
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dns.c.patch
Description:When an SRV lookup is done and there is no SRV record for the hostname, but there are other record types for the hostname in the answer, ast_search_dns() incorrectly returns that it found a match.

There is a small bug in the code causing ast_search_dns() to return '1' when it should be returning '0'.
Comments:By: Michiel van Baak (mvanbaak) 2007-09-01 14:08:41

Works fine on my system.
Since this is clearly a bug it should be fixed in 1.4 as well. in 1.4 it is line 270 of main/dns.c
By: Digium Subversion (svnbot) 2007-09-04 07:52:36

Repository: asterisk
Revision: 81435

------------------------------------------------------------------------
r81435 | file | 2007-09-04 07:52:34 -0500 (Tue, 04 Sep 2007) | 7 lines

(closes issue ASTERISK-10206)
Reported by: john
Patches:
     dns.c.patch uploaded by john (license 218)
Tested by: mvanbaak
Don't return a match if no SRV record actually exists.

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-09-04 07:53:26

Repository: asterisk
Revision: 81436

------------------------------------------------------------------------
r81436 | file | 2007-09-04 07:53:25 -0500 (Tue, 04 Sep 2007) | 15 lines

Merged revisions 81435 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81435 | file | 2007-09-04 10:10:56 -0300 (Tue, 04 Sep 2007) | 7 lines

(closes issue ASTERISK-10206)
Reported by: john
Patches:
     dns.c.patch uploaded by john (license 218)
Tested by: mvanbaak
Don't return a match if no SRV record actually exists.

........

------------------------------------------------------------------------