Summary:	ASTERISK-10187: [RFC] export attended transfer functionality over AMI
Reporter:	Paolo Ornati (ornati)	Labels:
Date Opened:	2007-08-28 14:00:17	Date Closed:	2008-03-05 18:17:03.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) ast1.4.[0..11]-atxferv3.diff ( 1) ast1.4.12,13-atxferv3.diff ( 2) atxfer-trunk.diff ( 3) atxfer-trunk-r90428.diff ( 4) atxfer-v1.diff ( 5) atxfer-v2.diff ( 6) atxfer-v3.diff
Description:	Currently there's no way (that I know) to activate an attended tranfer through the AMI, it would be useful for "controlling" GUIs etc... This patch export this functionality and passed the "works for me" stage. I'm interested in any type of feedback. In particular I'd like to know what the interface should look like. Now it's really simple, it just takes the "transferer" channel and the extension to transfer to. Should I also add optional "Context" and "Priority"?
Comments:	By: Paolo Ornati (ornati) 2007-08-29 14:14:09 atxfer-v2: After looking more at the code I've found that "Local" channel (used for doing attended transfer) doesn't really support "priority", just context/exten. Specify a priority on attended transfer doesn't make much sense anyway, I think. I've added support to specify "Context" (it's required, actually). By: Paolo Ornati (ornati) 2007-08-30 06:35:29 atxfer-v3: I've made "Context" optional and tested this a bit. I'll leave for a 2-weeks holiday later today so I will be off-line. I hope -v3 is good enough :) By: Paolo Ornati (ornati) 2007-10-19 09:59:32 I've added backports for 1.4.x, so everyone can test this without running trunk. I've not compile/run tested with every version but they should work :). By: Brandon Kruse (bkruse) 2007-10-30 09:26:51 Ping: Housekeeping, any update to this? Should we close this issue? -bk By: Paolo Ornati (ornati) 2007-10-30 13:15:39 Why close it? It's not merged yet!  :) PS: I'll attach an updated patch (just to make it apply cleanly to the latest trunk) By: Brandon Kruse (bkruse) 2007-10-30 13:39:39 Oh, my apologies. Any devs take a look at this? comments? -bk By: Olle Johansson (oej) 2007-12-01 11:37:35.000-0600 I'll take a look as soon as I merged the other AMI changes. By: Olle Johansson (oej) 2007-12-01 11:57:19.000-0600 You need to support the ActionID parameter like all other AMI actions. By: Paolo Ornati (ornati) 2007-12-01 13:35:33.000-0600 ActionID is handled by "astman_send_ack()" and "astman_send_error()"  :) By: Olle Johansson (oej) 2007-12-01 13:49:29.000-0600 That makes life easy... Ok then. By: Brandon Kruse (bkruse) 2007-12-06 09:36:32.000-0600 Oej, Did this every get merged in (even if it was to your awesome manager branch)? -bk By: Mark Michelson (mmichelson) 2008-03-04 11:21:44.000-0600 Since this issue has seen no visible progress since December, I am going to assign the issue to myself and get it merged into trunk as soon as possible, since this seems like a nice feature. By: Mark Michelson (mmichelson) 2008-03-05 16:23:05.000-0600 Okay, this patch was really well written and worked fine, BUT it we avoid adding new control frames if at all possible, especially a control frame which is only going to be used in one place in the code. So, I used the same idea you had, except that instead of queueing a control frame, I queue DTMF frames that correspond to what is set as the attended transfer DTMF sequence defined in features.conf. This has a few advantages: it only allows those who have permission to transfer calls to transfer calls via the Manager interface, it requires only code in manager.c to be changed, and there's no need to add a new control frame type. Thanks for the patch submission, it was a good one. I'm just sorry that it didn't get taken care of sooner. Commit will be going into trunk soon... By: Digium Subversion (svnbot) 2008-03-05 16:29:19.000-0600 Repository: asterisk Revision: 106236 U   trunk/CHANGES U   trunk/doc/manager_1_1.txt U   trunk/main/manager.c ------------------------------------------------------------------------ r106236 | mmichelson | 2008-03-05 16:29:18 -0600 (Wed, 05 Mar 2008) | 11 lines Adding the Atxfer manager command. With this, you may initiate an attended transfer over AMI (closes issue ASTERISK-10187) Reported by: ornati Patches:      atxfer-trunk-r90428.diff uploaded by ornati (license 210)  (with modifications from me) Tested by: putnopvut ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=106236 By: Digium Subversion (svnbot) 2008-03-05 18:17:03.000-0600 Repository: asterisk Revision: 106316 _U  branches/1.6.0/ ------------------------------------------------------------------------ r106316 | russell | 2008-03-05 18:17:03 -0600 (Wed, 05 Mar 2008) | 18 lines Blocked revisions 106236 via svnmerge ........ r106236 | mmichelson | 2008-03-05 16:33:05 -0600 (Wed, 05 Mar 2008) | 11 lines Adding the Atxfer manager command. With this, you may initiate an attended transfer over AMI (closes issue ASTERISK-10187) Reported by: ornati Patches:      atxfer-trunk-r90428.diff uploaded by ornati (license 210)  (with modifications from me) Tested by: putnopvut ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=106316