Summary:	ASTERISK-10179: Bad hangup-cause in Hangup event: 16 instead 19, for calls originated using AMI
Reporter:	Francisco Seratti (boch)	Labels:
Date Opened:	2007-08-27 16:59:58	Date Closed:	2008-01-11 13:10:04.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) hangupcause-rev81419.diff ( 1) hangupcause-rev-97698.patch
Description:	All the calls originated trough the AMI that aren't answered after alerting the user, are terminating with the cause 16 - normal clearing, instead 19 - no answer.
Comments:	By: Moises Silva (moy) 2007-09-01 13:14:55 Yeah, not sure if that is correct or not. But this behaviour is not present just in AMI, Dial() behaves the same way and I suppose other applications do the same. However here is a patch to try to correct that. Disclaimer OK. By: Moises Silva (moy) 2007-09-01 13:18:50 Hum ... it seems process has changed. I FAXed a disclaimer 1 year ago, but now mantis request me to sign a disclaimer. I have already done that, hopefully it will be accepted soon. In the meantime, boch, you can take the patch from here: http://www.moythreads.com/hangupcause-rev81419.diff By: Joshua C. Colp (jcolp) 2007-09-11 15:08:08 Can you please attach the patch so we can verify licensing on this? By: Moises Silva (moy) 2007-09-11 15:31:58 Done! By: Brandon Kruse (bkruse) 2007-10-30 09:28:30 License checks out, should we add this? If it has been added, please close, get this count down! -bk :] By: Brandon Kruse (bkruse) 2007-10-30 09:29:32 Hey file, can you take a look at this? You commented last, and he uploaded a disclaimer. -bk By: Michiel van Baak (mvanbaak) 2008-01-10 05:38:31.000-0600 The second 'if (....' part of your patch uses {} around a single command. Please remove them. </picky_mode> By: Moises Silva (moy) 2008-01-10 09:39:01.000-0600 mvanbaak: I addressed your comment and upgraded the patch for revision 97698. Sorry about that, my brain wasn't in "asterisk code" mode at that time. By: Michiel van Baak (mvanbaak) 2008-01-10 09:52:36.000-0600 moy, no problem :) The latest patch applies, compiles and works on my testbed. By: Digium Subversion (svnbot) 2008-01-11 13:09:17.000-0600 Repository: asterisk Revision: 98315 U   branches/1.4/main/channel.c ------------------------------------------------------------------------ r98315 | mmichelson | 2008-01-11 13:09:15 -0600 (Fri, 11 Jan 2008) | 5 lines Properly report the hangup cause as no answer when someone does not answer (closes issue ASTERISK-10179, reported by boch, patched by moy) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=98315 By: Digium Subversion (svnbot) 2008-01-11 13:10:04.000-0600 Repository: asterisk Revision: 98316 _U  trunk/ U   trunk/main/channel.c ------------------------------------------------------------------------ r98316 | mmichelson | 2008-01-11 13:09:59 -0600 (Fri, 11 Jan 2008) | 13 lines Merged revisions 98315 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r98315 | mmichelson | 2008-01-11 13:10:57 -0600 (Fri, 11 Jan 2008) | 5 lines Properly report the hangup cause as no answer when someone does not answer (closes issue ASTERISK-10179, reported by boch, patched by moy) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=98316