[Home]

Summary:ASTERISK-10167: Show if meetme is locked
Reporter:Russell Brown (ruffle)Labels:
Date Opened:2007-08-25 08:37:39Date Closed:2007-09-11 09:31:38
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) rb
( 1) svn.diff
Description:As far as I can see, there's no way from the CLI to see if a meetme is locked.

This two line patch adds the word 'Locked' to the output of meetme for locked
conferences.

Here's the trivial patch:

*** app_meetme.c   2007-08-09 17:12:57.000000000 +0100
--- asterisk-1.4.10.1/apps/app_meetme.c 2007-08-25 14:06:32.000000000 +0100
***************
*** 825,831 ****
       int i = 0, total = 0;
       time_t now;
       char *header_format = "%-14s %-14s %-10s %-8s  %-8s\n";
!       char *data_format = "%-12.12s   %4.4d         %4.4s       %02d:%02d:%02d  %-8s\n";
       char cmdline[1024] = "";
 
       if (argc > 8)
--- 825,831 ----
       int i = 0, total = 0;
       time_t now;
       char *header_format = "%-14s %-14s %-10s %-8s  %-8s\n";
!       char *data_format = "%-12.12s   %4.4d         %4.4s       %02d:%02d:%02d  %-8s%8s\n";
       char cmdline[1024] = "";
 
       if (argc > 8)
***************
*** 854,860 ****
                       min = ((now - cnf->start) % 3600) / 60;
                       sec = (now - cnf->start) % 60;
 
!                       ast_cli(fd, data_format, cnf->confno, cnf->users, cmdline, hr, min, sec, cnf->isdynamic ? "Dynamic" : "Static");
 
                       total += cnf->users;
               }
--- 854,860 ----
                       min = ((now - cnf->start) % 3600) / 60;
                       sec = (now - cnf->start) % 60;
 
!                       ast_cli(fd, data_format, cnf->confno, cnf->users, cmdline, hr, min, sec, cnf->isdynamic ? "Dynamic" : "Static",cnf->locked ? "Locked" : "");
 
                       total += cnf->users;
               }


Comments:By: Ronald Chan (loloski) 2007-08-25 10:31:03

ruffle,

Please attach the patch on svn diff format, so that developer's can easily pick this up.
By: Ronald Chan (loloski) 2007-08-25 10:33:00

ruffle,

One more thing the patch should apply against SVN-trunk, not on a release branch thank you!
By: Russell Brown (ruffle) 2007-08-25 11:09:33

svn diff added as requested.
By: Jason Parker (jparker) 2007-08-27 12:07:14

You should probably update the header_format lines to add a "Locked" column, and perhaps fill it with "Yes" or "No"
By: Russell Brown (ruffle) 2007-08-28 08:05:46

OK - the second attached svn diff has a column for Locked with a Yes on No
for each conference line.
By: Digium Subversion (svnbot) 2007-09-11 09:31:37

Repository: asterisk
Revision: 82242

------------------------------------------------------------------------
r82242 | file | 2007-09-11 09:31:37 -0500 (Tue, 11 Sep 2007) | 6 lines

(closes issue ASTERISK-10167)
Reported by: ruffle
Patches:
     rb uploaded by ruffle (license 201)
Show whether the conference is locked or not on the CLI.

------------------------------------------------------------------------