Summary:	ASTERISK-10156: [patch] Some characters (such as #) are not escaped in SIP headers
Reporter:	Leif Madsen (lmadsen)	Labels:
Date Opened:	2007-08-23 16:53:29	Date Closed:	2008-05-01 13:55:33
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Interoperability
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 20080418__bug10543.diff.txt
Description:	Had a conversation with OEJ yesterday about the '#' character not getting converted in all areas of the SIP headers to a %23. Here are some comments from our conversation: RFC 2396 says: "The character "#" is excluded because it is used to delimit a URI from a fragment identifier in URI references (Section 4)." The SIP RFC says: "Excluded US-ASCII characters (RFC 2396 [5]), such as space and control characters and characters used as URI delimiters, also MUST be escaped." ****** ADDITIONAL INFORMATION ****** The problem is that RFC2396 is not written for UTF8 and SIP URI's is UTF8, which allows for much more than mailto: uri's.
Comments:	By: Tilghman Lesher (tilghman) 2007-09-26 15:26:37 Okay, this sounds like a pedantic issue... have you found a device with which Asterisk fails to interoperate because of this issue? By: Leif Madsen (lmadsen) 2007-09-26 19:18:40 The Mediatrix device is at least one of them. Also, the Nortel PBX doesn't work either. By: Leif Madsen (lmadsen) 2007-11-05 09:07:35.000-0600 Pinging Sir oej! :) By: Olle Johansson (oej) 2007-11-05 14:30:55.000-0600 Oh, was this my wake-up call? By: Leif Madsen (lmadsen) 2007-11-05 14:35:41.000-0600 Yes sir! I'd like to move this issue forward if possible... or at least get a status update... By: Leif Madsen (lmadsen) 2008-02-11 09:35:29.000-0600 /housekeeping! You want mint for pillow? By: Tilghman Lesher (tilghman) 2008-04-18 15:48:37 I believe this is all that is actually needed, correct?  Testing desired. By: Digium Subversion (svnbot) 2008-05-01 13:53:49 Repository: asterisk Revision: 115017 U   branches/1.4/main/utils.c ------------------------------------------------------------------------ r115017 | tilghman | 2008-05-01 13:53:46 -0500 (Thu, 01 May 2008) | 6 lines '#' is another reserved character for URIs that also needs to be escaped. (closes issue ASTERISK-10156) Reported by: blitzrage Patches:       20080418__bug10543.diff.txt uploaded by Corydon76 (license 14) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115017 By: Digium Subversion (svnbot) 2008-05-01 13:54:46 Repository: asterisk Revision: 115018 _U  trunk/ U   trunk/main/utils.c ------------------------------------------------------------------------ r115018 | tilghman | 2008-05-01 13:54:44 -0500 (Thu, 01 May 2008) | 14 lines Merged revisions 115017 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115017 | tilghman | 2008-05-01 13:59:08 -0500 (Thu, 01 May 2008) | 6 lines '#' is another reserved character for URIs that also needs to be escaped. (closes issue ASTERISK-10156) Reported by: blitzrage Patches:       20080418__bug10543.diff.txt uploaded by Corydon76 (license 14) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115018 By: Digium Subversion (svnbot) 2008-05-01 13:55:33 Repository: asterisk Revision: 115020 _U  branches/1.6.0/ U   branches/1.6.0/main/utils.c ------------------------------------------------------------------------ r115020 | tilghman | 2008-05-01 13:55:32 -0500 (Thu, 01 May 2008) | 22 lines Merged revisions 115018 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r115018 | tilghman | 2008-05-01 14:00:18 -0500 (Thu, 01 May 2008) | 14 lines Merged revisions 115017 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115017 | tilghman | 2008-05-01 13:59:08 -0500 (Thu, 01 May 2008) | 6 lines '#' is another reserved character for URIs that also needs to be escaped. (closes issue ASTERISK-10156) Reported by: blitzrage Patches:       20080418__bug10543.diff.txt uploaded by Corydon76 (license 14) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115020