Summary:	ASTERISK-10149: When reloading moh and the directory is changed, the change doesn't apply
Reporter:	Theo Belder (tbelder)	Labels:
Date Opened:	2007-08-23 09:05:00	Date Closed:	2011-06-07 14:08:20
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_musiconhold
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-mohreload.diff.txt
Description:	When changing the directory in musiconhold.conf and commit a reload ('module reload res_musiconhold.so' or 'moh reload'), the filelist isn't updated. ****** ADDITIONAL INFORMATION ****** asterisk version: 1.4.11 musiconhold.conf: [default] mode=files directory=/var/lib/asterisk/moh random=no
Comments:	By: Jason Parker (jparker) 2007-08-23 10:28:12 This is done by design.  You cannot currently change an existing moh class. Closing. By: James Golovich (jamesgolovich) 2007-08-23 12:12:39 Heres a patch to allow reloads work fully.  This is against trunk but should work fine in 1.4.x.  Figured since I made some of the other moh reload stuff work recently it would be good to go the rest of the way By: Digium Subversion (svnbot) 2007-10-18 01:51:31 Repository: asterisk Revision: 86277 U   trunk/res/res_musiconhold.c ------------------------------------------------------------------------ r86277 | tilghman | 2007-10-18 01:51:31 -0500 (Thu, 18 Oct 2007) | 2 lines On reload, re-read the files in the specified moh directory (closes issue ASTERISK-10149) ------------------------------------------------------------------------ By: Clod Patry (junky) 2007-12-17 16:16:36.000-0600 Like I was discussing with russell on IRC. That patch could result in some problems: you can have 2 moh classes with the same name. Example: [default] mode=files directory=/var/lib/asterisk/moh [babysue] mode=files directory=/var/lib/asterisk/moh/babysue23 [babysue] mode=files directory=/var/lib/asterisk/moh/babysue3 rabbit*CLI> moh show classes Class: babysue        Mode: files        Directory: /var/lib/asterisk/moh/babysue3        Use Count: 0 Class: babysue        Mode: files        Directory: /var/lib/asterisk/moh/babysue23        Use Count: 0 Class: default        Mode: files        Directory: /var/lib/asterisk/moh        Use Count: 0 rabbit*CLI> these 2 classes have 2 different directories, but the same name and there's no warning at all, which is bad to my point of view. By: Clod Patry (junky) 2008-01-05 09:55:06.000-0600 closed since we merged this one with ASTERISK-11060.