Summary:	ASTERISK-10135: [patch] misleading check for AUTH_UNKNOWN_DOMAIN
Reporter:	Andrey S Pankov (casper)	Labels:
Date Opened:	2007-08-21 06:38:25	Date Closed:	2007-08-30 16:07:38
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Registration
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_sip.c.80129.diff
Description:	AUTH_UNKNOWN_DOMAIN case is handled earlier in the function code.
Comments:	By: Jason Parker (jparker) 2007-08-21 10:05:40 It looks like you're right.  Rather than setting res to AUTH_UNKNOWN_DOMAIN and then continuing on, it returns.  Thus, is appears that res can never be set to AUTH_UNKNOWN_DOMAIN right there. However, I'm a bit hesitant to make that change - and it probably wouldn't be appropriate to do in 1.4 (it doesn't actually fix anything - it just makes the code clearer). By: Andrey S Pankov (casper) 2007-08-21 10:13:27 Sorry, but I'd like to insist on that this changes is included in 1.4... :) By: Digium Subversion (svnbot) 2007-08-30 16:05:36 Repository: asterisk Revision: 81395 ------------------------------------------------------------------------ r81395 | file | 2007-08-30 16:05:35 -0500 (Thu, 30 Aug 2007) | 6 lines (closes issue ASTERISK-10135) Reported by: casper Patches:      chan_sip.c.80129.diff uploaded by casper (license 55) Remove needless check for AUTH_UNKNOWN_DOMAIN. It was impossible for it to ever be that value. ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-30 16:07:38 Repository: asterisk Revision: 81396 ------------------------------------------------------------------------ r81396 | file | 2007-08-30 16:07:37 -0500 (Thu, 30 Aug 2007) | 14 lines Merged revisions 81395 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r81395 | file | 2007-08-30 18:23:50 -0300 (Thu, 30 Aug 2007) | 6 lines (closes issue ASTERISK-10135) Reported by: casper Patches:      chan_sip.c.80129.diff uploaded by casper (license 55) Remove needless check for AUTH_UNKNOWN_DOMAIN. It was impossible for it to ever be that value. ........ ------------------------------------------------------------------------