[Home]

Summary:ASTERISK-10056: chan_sip.c HUGE bug
Reporter:copas2 (copas2)Labels:
Date Opened:2007-08-09 12:45:23Date Closed:2007-08-09 14:53:28
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:http://c16.xw.hu/download/chan_sip.zip
It's about chan_sip.c (Asterisk 1.4.10). I had to change it because since the last version (1.4.9) the developer called qwell made some changes and has ruined the canreinvite capability of the whole system. It seems he confused the canreinvite and insecure options in the code and mixed them up a little. I just copied the last working code segment to the corresponding section. If you make a diff between the latest chan_sip.c and the one I linked, you'll see the difference. The problem is that with 1.4.10 there is no canreinvite option anymore - it is always NO since it cannot be set because the code is corrupt. Please correct it the right way. Anyway, thanks for the great work.
Comments:By: Russell Bryant (russell) 2007-08-09 12:59:30

You must attach your patch as an attachment to this issue for us to look at it ...

By: Jason Parker (jparker) 2007-08-09 12:59:56

This appears to have changed in revision 78103.

http://svn.digium.com/view/asterisk/tags/1.4.10/channels/chan_sip.c?r1=77824&r2=78103

The last part of the patch confirms the problem here.

By: Mark Michelson (mmichelson) 2007-08-09 14:53:28

It wasn't qwell who broke the code, it was me. I've fixed it now and a new release (1.4.10.1) will be out later today or early tomorrow. For now, the issue has been fixed in svn revision 78826.