Summary:ASTERISK-10042: Application: SIPCallpickup for pickup up a call in the same pickup group
Reporter:Tobias Unsleber (tobiasunsleber)Labels:
Date Opened:2007-08-08 05:03:34Date Closed:2007-08-27 15:37:29
Versions:Frequency of
Environment:Attachments:( 0) ast_puapp_doc.diff
( 1) ast_puapp_doc2.diff
( 2) ast12_puapp_doc2.diff
Description:This application lets you pickup a call in the same pickup group. It's taken from voip-info.org without testing so far. Patch is attached. The patch changes only chan_sip.c from asterisk 1.2.23
Comments:By: Gregory Hinton Nietsky (irroot) 2007-08-08 05:40:58

i dont think any one is going to like you pasting code in the message ... nor will they like it that you assing features to 1.2 when it is end of life ...

Asterisk 1.2 was released in the Fall of 2005. At this time, Asterisk 1.0 was put into security maintenance, meaning that it only received changes to fix security issues, and not changes intended to fix less severe issues.

Asterisk 1.4 was released in the Fall of 2006. At this time, Asterisk 1.0 became officially unsupported. However, we continued to fully maintain Asterisk 1.2. Now that Asterisk 1.4 has been out for about 5 months, we are taking steps toward moving Asterisk 1.2 to security maintenance only. We plan on aiming for this to happen on August 1st, 2007.

this has been supported by features for a long time and now with a directed pickup why specificaly this patch ??

By: Tobias Unsleber (tobiasunsleber) 2007-08-08 06:25:09

Reason for this patch:
I have a case where I want to use GroupPickup from the dialplan and not through res_features, because I want to do something before and after the pickup. This "pickup app" appeared in voip-info.org wiki in form of manual installation hints. I want this patch to be available as normal patch somewhere in the internet, and I think here is a good place. I don't  propose this patch to be integrated in the official asterisk source tree.

By: Gregory Hinton Nietsky (irroot) 2007-08-08 06:41:41

i supose there is a case to be made for that ...

should be simple to wrap ast_pickup_call as a function to operate on all channels as the pickup function would ... or use the PICKUPMARK setting for app pickup.

modifying app pickup to pickup a group call ala functions when no options are given ... ??

sounds logical ??

By: Gregory Hinton Nietsky (irroot) 2007-08-08 06:50:01

there we go a real trivial patch that may do the trick it is against 1.4.9 but will probably apply to 1.2 as well.

By: Tobias Unsleber (tobiasunsleber) 2007-08-08 07:02:15

I would appreciate a simple dialplan wrapper app that would accomplish pickup by pickupgroup. My abilities to do this on my own are limited, but I'm trying...

By: Tilghman Lesher (tilghman) 2007-08-08 07:19:39

Uh, if this code was taken from voip-info.org, then the licensing is unclear.  You do NOT have implicit permission to take something from that site and upload it here.  Unless you can get a declaration from the original author of this patch, this is dead in the water.

By: Gregory Hinton Nietsky (irroot) 2007-08-08 07:22:34

ok here is a small fix to the "documented" version the patch i have supplied is a more corect patch than the voip-info and makes logic sense within asterisk.

it is licenced and you welcome to use it im certainaly recomending it included as it is a trivial extension of the pickup app and a logical one at that.

hope it works for you ...

By: Tobias Unsleber (tobiasunsleber) 2007-08-08 08:37:10

@Corydon76 - administrator: Thanks for the copyright reminder, maybe the in-text patch should be deleted, as it as far as I know now is not correctly working.

@irroot: I tried to apply your integrate your patch to app_directed_pickup from 1.2, and it compiles but it doesn't work. My try to patch 1.2.23 is uploaded. I'll test it on 1.4 if it works.

By: Tobias Unsleber (tobiasunsleber) 2007-08-08 09:07:36

The pickup application with your patch works for 1.4 and my version for 1.2 works. I only set "pickupgroup" in sip.conf and did not "callgroup", which is required too. Thanks a lot.

By: Gregory Hinton Nietsky (irroot) 2007-08-08 09:15:22

its a pleasure i had some time as you can see it is a quick and easy ...

the patch you posted is a bit convoluted in that it only works with sip and is a reinvention of the wheel.this will work with any channel driver.

By: Gregory Hinton Nietsky (irroot) 2007-08-20 08:49:31

no takers for this extension of app_pickup ... the summaty is misleading it basicaly alows Pickup to do a features pickup when no paramaters are passed to the app ...

currently the app barfs if no paramaters are passed ... i belive this is the sane and expected behavior of the app and a rather trivial change.

By: Digium Subversion (svnbot) 2007-08-27 15:37:29

Repository: asterisk
Revision: 81118

r81118 | tilghman | 2007-08-27 15:37:27 -0500 (Mon, 27 Aug 2007) | 2 lines

Enhance Pickup to do native pickupgroup pickup when no arguments are specified (closes issue ASTERISK-10042)