[Home]

Summary:ASTERISK-10039: Stutter tone not produced on FXS module when new voice mail is present
Reporter:Stephen (st1710)Labels:
Date Opened:2007-08-07 13:52:32Date Closed:2007-08-07 14:27:13
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Stutter tone not produced on FXS module when new voice mail is present. Problem apparently in app_voicemail.c using inboxcount().

****** ADDITIONAL INFORMATION ******

inboxcount() is references in has_voicemail() and messagecount() in app_voicemail.c at lines about 2594 and 2609

inboxcount appears to returns 0 on success, with valid values in newmsgs, oldmsgs. However, both functions do a test on the value of inboxcount and always return 0.

I.e:

if(inboxcount(mailbox, &newmsgs, &oldmsgs))
               return folder? oldmsgs: newmsgs;
       else
               return 0;

Hence, the functions return zero and no stutter tone is applied.
Comments:By: Digium Subversion (svnbot) 2007-08-07 14:26:23

Repository: asterisk
Revision: 78450

------------------------------------------------------------------------
r78450 | mmichelson | 2007-08-07 14:26:22 -0500 (Tue, 07 Aug 2007) | 5 lines

The logic behind inboxcount's return value was reversed in has_voicemail and message_count.

(closes issue ASTERISK-10039, reported by st1710, patched by me)


------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-08-07 14:27:13

Repository: asterisk
Revision: 78451

------------------------------------------------------------------------
r78451 | mmichelson | 2007-08-07 14:27:13 -0500 (Tue, 07 Aug 2007) | 13 lines

Merged revisions 78450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r78450 | mmichelson | 2007-08-07 14:43:57 -0500 (Tue, 07 Aug 2007) | 5 lines

The logic behind inboxcount's return value was reversed in has_voicemail and message_count.

(closes issue ASTERISK-10039, reported by st1710, patched by me)


........

------------------------------------------------------------------------