Summary:	ASTERISK-10006: [patch] vnak_retransmit sends out incorrect frames
Reporter:	mihai (mihai)	Labels:
Date Opened:	2007-08-01 15:23:21	Date Closed:	2007-08-02 11:41:01
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_iax2
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) extra_vnak_retransmit_checks.patch
Description:	vnak_retransmit should do some more exhaustive checks on the frames it sends out as a reply to a VNAK: - check if retries == -1 (if true, the frame was marked for deletion) - check if the destination callno of the frame is equal to our call's destination callno
Comments:	By: mihai (mihai) 2007-08-01 15:24:19 Uploaded a patch that adds these checks.  Forgot to add [Patch] to the bug description... :) By: Russell Bryant (russell) 2007-08-02 11:36:24 I think I'm going to commit only the "retries" check part.  I can't think of any case where the peer call number check would be beneficial unless the code was broken. ... On second thought, I think checking the peer call number could actually cause a problem.  Specifically, the first frame of a session doesn't have the peer's call number in it.  This check would prevent it from getting retransmitted. By: Digium Subversion (svnbot) 2007-08-02 11:38:39 Repository: asterisk Revision: 77939 ------------------------------------------------------------------------ r77939 | russell | 2007-08-02 11:38:38 -0500 (Thu, 02 Aug 2007) | 4 lines Add another sanity check to vnak_retransmit().  This check ensures that frames that have already been marked for deletion don't get retransmitted. (closes issue ASTERISK-10006, patch from mihai) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-02 11:41:01 Repository: asterisk Revision: 77940 ------------------------------------------------------------------------ r77940 | russell | 2007-08-02 11:41:00 -0500 (Thu, 02 Aug 2007) | 12 lines Merged revisions 77939 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77939 | russell | 2007-08-02 11:56:04 -0500 (Thu, 02 Aug 2007) | 4 lines Add another sanity check to vnak_retransmit().  This check ensures that frames that have already been marked for deletion don't get retransmitted. (closes issue ASTERISK-10006, patch from mihai) ........ ------------------------------------------------------------------------