Summary:	ASTERISK-09983: SIP history is recorded for many (not all) items even when recording is off
Reporter:	Jon Moldenauer (jmoldenhauer)	Labels:
Date Opened:	2007-08-09 12:11:14	Date Closed:	2007-08-21 13:31:27
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch.1
Description:	By default, SIP history recording and dumphistory is disabled.  However, even though it is disabled (and confirmed to be disabled through the CLI command sip show history xxx), the history is still recorded due to improper use of the "append_history" function/macro without wrapping it with a check to see if recording is on or off. ****** ADDITIONAL INFORMATION ****** In prior versions of asterisk (not sure which version), the append_history... function specifically checked to see if history was to be recorded or not.  At some point in time (haven't been able to determine where) that changed.  However, code that calls append_history was not updated to check the record history status. I have a proposed fixed, albeit very trivial, that should prevent history from being recorded unless history recording is enabled at the SIP dialog level, the global level (recordhistory), or the dump history option is on for which history must be recorded for it to have anything to dump.
Comments:	By: Jon Moldenauer (jmoldenhauer) 2007-08-09 12:13:38 I forgot to mention that the reason this is a problem is because it can cause Asterisk to use more memory than it needs to in chan_sip. By: Russell Bryant (russell) 2007-08-09 13:02:53 This is basically the same issue as 10421, so I'm closing this out as a duplicate. By: Digium Subversion (svnbot) 2007-08-21 13:24:20 Repository: asterisk Revision: 80183 ------------------------------------------------------------------------ r80183 | russell | 2007-08-21 13:24:18 -0500 (Tue, 21 Aug 2007) | 7 lines Don't record SIP dialog history if it's not turned on.  Also, put an upper limit on how many history entires will be stored for each SIP dialog.  It is currently set to 50, but can be increased if deemed necessary. (closes issue ASTERISK-10057, closes issue ASTERISK-9983, patches suggested by jmoldenhauer, patches updated by me) (Security implications documented in AST-2007-020) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-21 13:31:27 Repository: asterisk Revision: 80184 ------------------------------------------------------------------------ r80184 | russell | 2007-08-21 13:31:25 -0500 (Tue, 21 Aug 2007) | 15 lines Merged revisions 80183 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80183 | russell | 2007-08-21 13:42:15 -0500 (Tue, 21 Aug 2007) | 7 lines Don't record SIP dialog history if it's not turned on.  Also, put an upper limit on how many history entires will be stored for each SIP dialog.  It is currently set to 50, but can be increased if deemed necessary. (closes issue ASTERISK-10057, closes issue ASTERISK-9983, patches suggested by jmoldenhauer, patches updated by me) (Security implications documented in AST-2007-020) ........ ------------------------------------------------------------------------