[Home]

Summary:ASTERISK-09955: 7920 Phone Screen Not cleared after Call
Reporter:sbisker (sbisker)Labels:
Date Opened:2007-07-25 08:05:47Date Closed:2007-08-02 13:26:16
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_skinny-clearscreen.diff.txt
( 1) skinny-10299.diff
Description:Similar to closed issue 0009958.  On the 7920 phone, the phone still displays "Connected" when the call is completed.
Comments:By: pj (pj) 2007-07-25 10:06:54

I have not this issue (I'm using asterisk trunk version), firmware 3.02 for 7920.
Asterisk SVN-trunk-r75505


By: sbisker (sbisker) 2007-07-25 10:24:42

I have the same Firmware version on my phones as well.  What SVN version are you running?  Also, incoming calls display "Ring-In" even after the call is completed.


By: Jason Parker (jparker) 2007-07-25 11:50:38

I'd be willing to be bet that this has the same cause as ASTERISK-9948


By: sbisker (sbisker) 2007-08-01 13:36:22

The recent fix for bug 0010291  does not fix the problem with the 7920 phones.  The 7921 phones display the messages correctly.
By: sbisker (sbisker) 2007-08-02 10:11:21

This small patch fixes the problem.

Needed to call

transmit_displaypromptstatus(s, 0, 0, l->instance, sub->callid);

for each side of the call in skinny_hangup.
By: Jason Parker (jparker) 2007-08-02 11:20:00

The trace I have (let's just assume it's a "normal" call, where the device is offhook) shows the following order:

CloseReceiveChannel
StopMediaTransmission
SetSpeakerModeMessage (SpeakerOff)
ClearPromptStatusMessage   <--- Yep, you're right.
CallStateMessage
SelectSoftKeysMessage (OnHook)
DisplayPromptStatusMessage (\200\023 - I'm not sure what this translates to)
ActivateCallPlaneMessage


transmit_callstate() with SKINNY_ONHOOK does:
SetSpeakerModeMessage (SpeakerOff)
ActivateCallPlaneMessage
CloseReceiveChannel
StopMediaTransmission
CallStateMessage


That's pretty badly out of order, and we're missing 3 things...I think we need to fix all of that.

Give me a little bit, and I'll come up with a patch.
By: Jason Parker (jparker) 2007-08-02 13:05:05

Uploaded patch.  Give that a try.

It rearranges some of the messages, and also adds the ClearPromptStatusMessage in the OnHook state.
By: sbisker (sbisker) 2007-08-02 13:12:26

That worked.
By: Jason Parker (jparker) 2007-08-02 13:13:59

Just to make sure - before applying this, you reverted your patch, right?
By: sbisker (sbisker) 2007-08-02 13:15:40

Yes, I removed the previous changes I had made.
By: Digium Subversion (svnbot) 2007-08-02 13:26:16

Repository: asterisk
Revision: 77948

------------------------------------------------------------------------
r77948 | qwell | 2007-08-02 13:26:16 -0500 (Thu, 02 Aug 2007) | 14 lines

Merged revisions 77947 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue ASTERISK-9955)
........
r77947 | qwell | 2007-08-02 13:42:36 -0500 (Thu, 02 Aug 2007) | 5 lines

Make sure we clear the prompt status message on a hangup.
Also rearrange messages to better fit with what a wireshark trace shows it should be.

Issue 10299, initial patch and solution by sbisker, modified by me to fit with wireshark trace.

........

------------------------------------------------------------------------