Summary:	ASTERISK-09937: [patch] Make 'agi_network: yes' show up with agi debugging on (and handle partial writes)
Reporter:	Sean Bright (seanbright)	Labels:
Date Opened:	2007-07-23 20:47:50	Date Closed:	2007-07-30 14:23:36
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_agi
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) res_agi.carefulwrite.1.4.07252007.patch ( 1) res_agi.carefulwrite.1.4.patch ( 2) res_agi.carefulwrite.trunk.07252007.patch ( 3) res_agi.carefulwrite.trunk.patch
Description:	Simple patch that will print "agi_network: yes" to the CLI when doing AGI debugging and also handle partial writes to the FastAGI by calling fdprintf (which just calls ast_carefulwrite) instead of write() directly.  Patch for trunk and for 1.4 attached.
Comments:	By: Sean Bright (seanbright) 2007-07-24 08:49:21 Sorry, forgot to add the SVN revision number and I can't find a way to edit the report.  The patch against trunk is for revision 76711. By: Sean Bright (seanbright) 2007-07-25 08:41:08 Removed an unncessary assignment and updated patches against the latest revisions of each branch. By: Digium Subversion (svnbot) 2007-07-30 13:56:10 Repository: asterisk Revision: 77788 ------------------------------------------------------------------------ r77788 | russell | 2007-07-30 13:56:09 -0500 (Mon, 30 Jul 2007) | 10 lines (closes issue ASTERISK-9937) Reported by: seanbright Patches:      res_agi.carefulwrite.1.4.07252007.patch uploaded by seanbright (license 71)      res_agi.carefulwrite.trunk.07252007.patch uploaded by seanbright (license 71) Allow the "agi_network: yes" line to be printed out in the AGI debug output. Also, allow partial writes to be handled when writing out this line just like it is for all of the others. ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-30 14:01:04 Repository: asterisk Revision: 77789 ------------------------------------------------------------------------ r77789 | russell | 2007-07-30 14:01:04 -0500 (Mon, 30 Jul 2007) | 18 lines Merged revisions 77788 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77788 | russell | 2007-07-30 14:13:31 -0500 (Mon, 30 Jul 2007) | 10 lines (closes issue ASTERISK-9937) Reported by: seanbright Patches:      res_agi.carefulwrite.1.4.07252007.patch uploaded by seanbright (license 71)      res_agi.carefulwrite.trunk.07252007.patch uploaded by seanbright (license 71) Allow the "agi_network: yes" line to be printed out in the AGI debug output. Also, allow partial writes to be handled when writing out this line just like it is for all of the others. ........ ------------------------------------------------------------------------ By: Donny Kavanagh (donnyk) 2007-07-30 14:19:35 from -dev mailing list: Missed an assignment: -       ast_carefulwrite(fd, stuff, strlen(stuff), 100); +       res = ast_carefulwrite(fd, stuff, strlen(stuff), 100); Sean By: Russell Bryant (russell) 2007-07-30 14:23:35 Fixed!  Thanks