| Summary: | ASTERISK-09904: polarity detection fixes (chan_zap) | ||
| Reporter: | Julian J. M. (julianjm) | Labels: | |
| Date Opened: | 2007-07-19 11:05:45 | Date Closed: | 2007-12-13 15:39:35.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_zap |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_zap.c-1.4-polarity-v5-disclaimer.diff.txt | |
| Description: | Current 1.4 branch (and 1.2 as reported by some) has trouble detecting remote disconnects on inbound calls that has been answered. ****** ADDITIONAL INFORMATION ****** It's just initialization issue, which is fixed in this patch. I've also supressed some code that breaks when used in Spain. It would reset polarity upon RING, which doesn't make really sense. As a plus, there is also a fix for detecting remote disconnects while we were trying to decode callerid. Otherwise, this polarity reversal would go unnoticed, and the channel would never hangup. Julian J. M. | ||
| Comments: | By: Julian J. M. (julianjm) 2007-07-19 11:10:11 I cannot seem to sign the license agreement, the capcha image is always wrong (and I tried several times). Anyway, i had faxed a disclaimer 1 or 2 years ago from this same username. Julian. By: Jason Parker (jparker) 2007-07-19 12:50:19 All fields are required in the license agreement. The error message is sometimes a bit misleading. You'll need to fill out a license agreement in order for us to review/use this code. By: Guillermo Salas M. (razametal) 2007-08-01 22:20:05 I'm using the patch on asterisk 1.4.9 at Ecuador - South America. It works very fine. By: david calvache (dcalvache) 2007-10-23 11:47:26 Im using julian´s patch in spain, it works very well too here. By: Digium Subversion (svnbot) 2007-12-13 15:25:41.000-0600 Repository: asterisk Revision: 92815 U branches/1.4/channels/chan_zap.c ------------------------------------------------------------------------ r92815 | tilghman | 2007-12-13 15:25:39 -0600 (Thu, 13 Dec 2007) | 5 lines Properly initialize polarity statuses, so that they are detected properly. Reported by: julianjm Patch by: julianjm (Closes issue ASTERISK-9904) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=92815 By: Digium Subversion (svnbot) 2007-12-13 15:39:34.000-0600 Repository: asterisk Revision: 92816 _U trunk/ U trunk/channels/chan_zap.c ------------------------------------------------------------------------ r92816 | tilghman | 2007-12-13 15:39:32 -0600 (Thu, 13 Dec 2007) | 13 lines Merged revisions 92815 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r92815 | tilghman | 2007-12-13 15:28:39 -0600 (Thu, 13 Dec 2007) | 5 lines Properly initialize polarity statuses, so that they are detected properly. Reported by: julianjm Patch by: julianjm (Closes issue ASTERISK-9904) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=92816 | ||