| Summary: | ASTERISK-09903: Incorrect handling of out of order full frames | ||
| Reporter: | mihai (mihai) | Labels: | |
| Date Opened: | 2007-07-19 10:04:29 | Date Closed: | 2007-07-19 10:36:48 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_iax2 |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 06asterisk-1.4-vnak-fixes.patch | |
| Description: | The code that handles full frames that arrive out of order does not take into account the fact that sequence numbers are 8 bit values that wrap around. If there is a lost or duplicate frame around the time of a wrap around, the server may send an erroneous VNAK or may not send a VNAK when one is required. In 1.4.8 release tarball, this happens in chan_iax2.c, on or around line 6717. ****** ADDITIONAL INFORMATION ****** This issue is similar to bug ASTERISK-9898, but happens in an opposite scenario. The solution should be similar. This was discovered in 1.4.8 but similar code is present in trunk and 1.2.x | ||
| Comments: | By: Digium Subversion (svnbot) 2007-07-19 10:32:43 Repository: asterisk Revision: 75927 ------------------------------------------------------------------------ r75927 | russell | 2007-07-19 10:32:42 -0500 (Thu, 19 Jul 2007) | 6 lines When processing full frames, take sequence number wraparound into account when deciding whether or not we need to request retransmissions by sending a VNAK. This code could cause VNAKs to be sent erroneously in some cases, and to not be sent in other cases when it should have been. (closes issue ASTERISK-9903, reported and patched by mihai) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-19 10:36:14 Repository: asterisk Revision: 75928 ------------------------------------------------------------------------ r75928 | russell | 2007-07-19 10:36:13 -0500 (Thu, 19 Jul 2007) | 14 lines Merged revisions 75927 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75927 | russell | 2007-07-19 10:49:42 -0500 (Thu, 19 Jul 2007) | 6 lines When processing full frames, take sequence number wraparound into account when deciding whether or not we need to request retransmissions by sending a VNAK. This code could cause VNAKs to be sent erroneously in some cases, and to not be sent in other cases when it should have been. (closes issue ASTERISK-9903, reported and patched by mihai) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-19 10:36:48 Repository: asterisk Revision: 75929 ------------------------------------------------------------------------ r75929 | russell | 2007-07-19 10:36:48 -0500 (Thu, 19 Jul 2007) | 22 lines Merged revisions 75928 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r75928 | russell | 2007-07-19 10:53:15 -0500 (Thu, 19 Jul 2007) | 14 lines Merged revisions 75927 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75927 | russell | 2007-07-19 10:49:42 -0500 (Thu, 19 Jul 2007) | 6 lines When processing full frames, take sequence number wraparound into account when deciding whether or not we need to request retransmissions by sending a VNAK. This code could cause VNAKs to be sent erroneously in some cases, and to not be sent in other cases when it should have been. (closes issue ASTERISK-9903, reported and patched by mihai) ........ ................ ------------------------------------------------------------------------ | ||