[Home]

Summary:ASTERISK-09901: [patch] where possible replace uses of channel->_softhangup with ast_check_hangup(channel)
Reporter:Donny Kavanagh (donnyk)Labels:
Date Opened:2007-07-18 12:44:32Date Closed:2008-12-10 10:29:17.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast_check_hangup-trunk.patch
Description:This is a step in the right direction but still doesn't remove many of the cases where we access many _variables directaly outside where we should be.
Comments:By: Russell Bryant (russell) 2007-07-30 10:16:13

After looking into this in more detail, I was mistaken on the usage of ast_check_hangup.  It can not be used as a drop-in replacement for checking the _softhangup variable.  You can schedule a channel to be hung up an hour from now, which will cause this function to return true.  However, applications that are running on the channel shouldn't care.  They only need to know if it has already been hung up.
By: Russell Bryant (russell) 2007-08-01 10:16:27

Earlier this morning I realized that this comment was wrong.  I'm going to apply the patch now ...
By: Digium Subversion (svnbot) 2007-08-01 10:22:33

Repository: asterisk
Revision: 77858

------------------------------------------------------------------------
r77858 | russell | 2007-08-01 10:22:31 -0500 (Wed, 01 Aug 2007) | 5 lines

Convert code that checks the _softhangup member of ast_channel directory to use
the ast_check_hangup() funciton.  This function takes scheduled hangups into
account.
(closes issue ASTERISK-9901, patch by Juggie)

------------------------------------------------------------------------