[Home]

Summary:ASTERISK-09884: [patch] res_agi, some long outstanding hacks, move chan->_softhangup to ast_check_hangup
Reporter:Donny Kavanagh (donnyk)Labels:
Date Opened:2007-07-16 18:14:08Date Closed:2007-07-19 10:42:20
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 10210-1.4-grr.patch
( 1) res_agi.patch
Description:This patch

#1 -> Changes the chan->_softhangup checks to ast_check_hangup(chan) calls.

#2 -> Blocks you from running AGI/EAGI on channel thats dead (rather then just a warning)

#3 -> Blocks you from running DeadAGI on a channel thats live (rather then just a warning)

****** ADDITIONAL INFORMATION ******

This patch requires that bug ASTERISK-9883 be resolved.
Comments:By: Donny Kavanagh (donnyk) 2007-07-16 18:15:17

I neglected to flag the file as code, could a bug Marshall fix that for me, thanks.
By: Donny Kavanagh (donnyk) 2007-07-17 11:49:43

posted a patch for 1.4 which adds a warning, but doesn't change any functionality.
By: Leif Madsen (lmadsen) 2007-07-17 12:02:14

Testing the 1.4 patches for 10209 and 10210 together, and get the WARNING as expected when running a DeadAGI() on a live channel.
By: Donny Kavanagh (donnyk) 2007-07-17 12:06:34

Thanks blitzrage
By: Donny Kavanagh (donnyk) 2007-07-17 13:22:50

Russ, this patch is ready to be tested/committed.
By: Leif Madsen (lmadsen) 2007-07-17 13:24:39

Per Juggie's request on IRC
By: Leif Madsen (lmadsen) 2007-07-17 13:25:15

Ugh... lets try this again
By: Digium Subversion (svnbot) 2007-07-17 15:16:13

Repository: asterisk
Revision: 75437

------------------------------------------------------------------------
r75437 | russell | 2007-07-17 15:16:11 -0500 (Tue, 17 Jul 2007) | 8 lines

(issue ASTERISK-9884)
Reported by: juggie
Patches:
     10210-1.4-grr.patch uploaded by juggie (license ASTERISK-20)
Tested by: juggie, blitzrage

Log a warning if someone uses DeadAGI on a live channel.

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-07-17 15:17:55

Repository: asterisk
Revision: 75438

------------------------------------------------------------------------
r75438 | russell | 2007-07-17 15:17:54 -0500 (Tue, 17 Jul 2007) | 15 lines

Blocked revisions 75437 via svnmerge

........
r75437 | russell | 2007-07-17 15:33:06 -0500 (Tue, 17 Jul 2007) | 8 lines

(issue ASTERISK-9884)
Reported by: juggie
Patches:
     10210-1.4-grr.patch uploaded by juggie (license ASTERISK-20)
Tested by: juggie, blitzrage

Log a warning if someone uses DeadAGI on a live channel.

........

------------------------------------------------------------------------
By: Donny Kavanagh (donnyk) 2007-07-17 15:33:49

Thanks for committing, i eagerly await the commit to trunk :)
By: Digium Subversion (svnbot) 2007-07-19 10:42:18

Repository: asterisk
Revision: 75930

------------------------------------------------------------------------
r75930 | russell | 2007-07-19 10:42:17 -0500 (Thu, 19 Jul 2007) | 6 lines

(closes issue ASTERISK-9884, reported and patched by juggie)

This merges the trunk only part of the patches from this issue.  In 1.4, res_agi
will issue a warning if you try to use DeadAGI on a channel that is not hung up.
Now, in trunk, it just plain won't let you do it.

------------------------------------------------------------------------