[Home]

Summary:ASTERISK-09881: Extraneous newline in AGI debugging output
Reporter:Sean Bright (seanbright)Labels:
Date Opened:2007-07-16 11:41:14Date Closed:2007-07-17 14:29:21
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_agi.patch
Description:Line 136 of res_agi.c tacks a newline onto the end of the debugging output, yet all calls to agi_debug_cli already include the newline.  So when debugging you get a blank line for no reason.
Comments:By: Sean Bright (seanbright) 2007-07-17 09:20:55

Patch attached in all of its one-line-gloriness.
By: Jason Parker (jparker) 2007-07-17 11:13:47

This seems like the right thing to do, but probably only in trunk.
By: Sean Bright (seanbright) 2007-07-17 11:40:51

Really?  Doesn't seem like it would break any functionality in 1.4, though.  Unless there are people that parse agi debugging output, which in and off itself seems like a silly concept.  It doesn't matter to me either way, I can just locally patch 1.4 if need be.
By: Digium Subversion (svnbot) 2007-07-17 14:28:16

Repository: asterisk
Revision: 75401

------------------------------------------------------------------------
r75401 | russell | 2007-07-17 14:28:14 -0500 (Tue, 17 Jul 2007) | 3 lines

Remove a duplicated newline character in AGI debug output.
(closes issue ASTERISK-9881, patch by seanbright)

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-07-17 14:29:21

Repository: asterisk
Revision: 75402

------------------------------------------------------------------------
r75402 | russell | 2007-07-17 14:29:19 -0500 (Tue, 17 Jul 2007) | 11 lines

Merged revisions 75401 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r75401 | russell | 2007-07-17 14:45:07 -0500 (Tue, 17 Jul 2007) | 3 lines

Remove a duplicated newline character in AGI debug output.
(closes issue ASTERISK-9881, patch by seanbright)

........

------------------------------------------------------------------------